jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/350795 )
Change subject: CX2: Simplify the link card stacking styles ...................................................................... CX2: Simplify the link card stacking styles Instead of using position:relative and top values, margin-top also works and avoids side effects to other cards in tools column. Change-Id: Ic2bb54c4da8b95c04f5879397d4d6e57b3c3d40f --- M modules/tools/styles/mw.cx.tools.LinkTool.less M modules/tools/styles/mw.cx.tools.NewLinkTool.less 2 files changed, 3 insertions(+), 14 deletions(-) Approvals: jenkins-bot: Verified Nikerabbit: Looks good to me, approved diff --git a/modules/tools/styles/mw.cx.tools.LinkTool.less b/modules/tools/styles/mw.cx.tools.LinkTool.less index aee33ab..1fe6049 100644 --- a/modules/tools/styles/mw.cx.tools.LinkTool.less +++ b/modules/tools/styles/mw.cx.tools.LinkTool.less @@ -7,7 +7,7 @@ .background-image-svg('../images/link_lightgray.svg', '../images/link_lightgray.png'); background-size: 30% 100%; background-position: top left; - transition: top 0.3s; + transition: margin 0.3s; min-height: 100px; .cx-widget-translationtool-header { @@ -47,10 +47,9 @@ // Stack the source and target link cards .cx-card-sourcelink + .cx-card-targetlink { - position: relative; - top: -90px; + margin-top: -90px; } .cx-card-sourcelink:hover + .cx-card-targetlink { - top: 0; + margin-top: 0; } diff --git a/modules/tools/styles/mw.cx.tools.NewLinkTool.less b/modules/tools/styles/mw.cx.tools.NewLinkTool.less index 13bc471..7fd40e4 100644 --- a/modules/tools/styles/mw.cx.tools.NewLinkTool.less +++ b/modules/tools/styles/mw.cx.tools.NewLinkTool.less @@ -44,13 +44,3 @@ } } } - -// Stack the source and target link cards -.cx-card-sourcelink ~ .cx-card-newlink { - position: relative; - top: -90px; -} - -.cx-card-sourcelink:hover ~ .cx-card-newlink { - top: 0; -} -- To view, visit https://gerrit.wikimedia.org/r/350795 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2bb54c4da8b95c04f5879397d4d6e57b3c3d40f Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ContentTranslation Gerrit-Branch: master Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com> Gerrit-Reviewer: Nikerabbit <niklas.laxst...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits