MaxSem has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/350908 )

Change subject: Sort user groups
......................................................................

Sort user groups

Without it, Special:UserRights sometimes fails with a
bogus conflict error just because groups are somehow ordered differently.

Change-Id: I9c7f51338e0849d9e134dc780eb13c542960c655
---
M includes/user/UserGroupMembership.php
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/08/350908/1

diff --git a/includes/user/UserGroupMembership.php 
b/includes/user/UserGroupMembership.php
index 81a4083..e8b22c4 100644
--- a/includes/user/UserGroupMembership.php
+++ b/includes/user/UserGroupMembership.php
@@ -332,6 +332,7 @@
                                $ugms[$ugm->group] = $ugm;
                        }
                }
+               ksort( $ugms );
 
                return $ugms;
        }

-- 
To view, visit https://gerrit.wikimedia.org/r/350908
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9c7f51338e0849d9e134dc780eb13c542960c655
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: MaxSem <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to