jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/351105 )
Change subject: Fix minor lint errors and typos
......................................................................
Fix minor lint errors and typos
* Commas that should be semicolons
* Unnecessary 'call's
Change-Id: I11a80702b5396a36e3deecc6e706a397cc354bd8
---
M modules/ve-mw/ce/nodes/ve.ce.MWTransclusionNode.js
M modules/ve-mw/dm/nodes/ve.dm.MWBlockImageNode.js
M modules/ve-mw/dm/nodes/ve.dm.MWInlineImageNode.js
M modules/ve-mw/init/ve.init.mw.ArticleTarget.js
4 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/modules/ve-mw/ce/nodes/ve.ce.MWTransclusionNode.js
b/modules/ve-mw/ce/nodes/ve.ce.MWTransclusionNode.js
index 816bf46..a8c100f 100644
--- a/modules/ve-mw/ce/nodes/ve.ce.MWTransclusionNode.js
+++ b/modules/ve-mw/ce/nodes/ve.ce.MWTransclusionNode.js
@@ -157,7 +157,7 @@
var contentNodes;
if ( ve.getProp( response, 'visualeditor', 'result' ) !== 'success' ) {
- return this.onParseError.call( this, deferred );
+ return this.onParseError( deferred );
}
// Work around https://github.com/jquery/jquery/issues/1997
diff --git a/modules/ve-mw/dm/nodes/ve.dm.MWBlockImageNode.js
b/modules/ve-mw/dm/nodes/ve.dm.MWBlockImageNode.js
index f208c47..ff96631 100644
--- a/modules/ve-mw/dm/nodes/ve.dm.MWBlockImageNode.js
+++ b/modules/ve-mw/dm/nodes/ve.dm.MWBlockImageNode.js
@@ -93,7 +93,7 @@
typeofAttrs.splice( errorIndex, 1 );
}
- types = this.rdfaToTypes[ typeofAttrs[ 0 ] ],
+ types = this.rdfaToTypes[ typeofAttrs[ 0 ] ];
attributes = {
mediaClass: types.mediaClass,
diff --git a/modules/ve-mw/dm/nodes/ve.dm.MWInlineImageNode.js
b/modules/ve-mw/dm/nodes/ve.dm.MWInlineImageNode.js
index 5fe790e..0187c7a 100644
--- a/modules/ve-mw/dm/nodes/ve.dm.MWInlineImageNode.js
+++ b/modules/ve-mw/dm/nodes/ve.dm.MWInlineImageNode.js
@@ -63,7 +63,7 @@
typeofAttrs.splice( errorIndex, 1 );
}
- types = this.rdfaToTypes[ typeofAttrs[ 0 ] ],
+ types = this.rdfaToTypes[ typeofAttrs[ 0 ] ];
attributes = {
mediaClass: types.mediaClass,
diff --git a/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
b/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
index e033b48..caa9ea8 100644
--- a/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
+++ b/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
@@ -1424,7 +1424,7 @@
return new mw.Api().postWithToken( 'csrf', postData, {
contentType: 'multipart/form-data' } );
}
- preparedCacheKey = this.getPreparedCacheKey( doc ),
+ preparedCacheKey = this.getPreparedCacheKey( doc );
data = ve.extendObject( {}, options, { format: 'json' } );
function ajaxRequest( cachekey, isRetried ) {
--
To view, visit https://gerrit.wikimedia.org/r/351105
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I11a80702b5396a36e3deecc6e706a397cc354bd8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
