Sbisson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/351183 )
Change subject: RC Filters: Fix subset registrations
......................................................................
RC Filters: Fix subset registrations
Bug: T163843
Change-Id: I7ba11abc9279326b4794a14b8249a3f717f831bd
---
M includes/Hooks.php
1 file changed, 10 insertions(+), 10 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ORES
refs/changes/83/351183/1
diff --git a/includes/Hooks.php b/includes/Hooks.php
index cf67aef..c716bfc 100644
--- a/includes/Hooks.php
+++ b/includes/Hooks.php
@@ -106,7 +106,7 @@
$damagingLevels = $stats->getThresholds( 'damaging' );
$filters = [];
if ( isset( $damagingLevels[ 'likelygood' ] ) ) {
- $filters[] = [
+ $filters[ 'likelygood' ] = [
'name' => 'likelygood',
'label' =>
'ores-rcfilters-damaging-likelygood-label',
'description' =>
'ores-rcfilters-damaging-likelygood-desc',
@@ -118,7 +118,7 @@
];
}
if ( isset( $damagingLevels[ 'maybebad' ] ) ) {
- $filters[] = [
+ $filters[ 'maybebad' ] = [
'name' => 'maybebad',
'label' =>
'ores-rcfilters-damaging-maybebad-label',
'description' =>
'ores-rcfilters-damaging-maybebad-desc',
@@ -130,7 +130,7 @@
];
}
if ( isset( $damagingLevels[ 'likelybad' ] ) ) {
- $filters[] = [
+ $filters[ 'likelybad' ] = [
'name' => 'likelybad',
'label' =>
'ores-rcfilters-damaging-likelybad-label',
'description' =>
'ores-rcfilters-damaging-likelybad-desc',
@@ -142,7 +142,7 @@
];
}
if ( isset( $damagingLevels[ 'verylikelybad' ] ) ) {
- $filters[] = [
+ $filters[ 'verylikelybad' ] = [
'name' => 'verylikelybad',
'label' =>
'ores-rcfilters-damaging-verylikelybad-label',
'description' =>
'ores-rcfilters-damaging-verylikelybad-desc',
@@ -164,7 +164,7 @@
'Special:MyLanguage/Help:New_filters_for_edit_review/Quality_and_Intent_Filters',
'whatsThisLinkText' =>
'ores-rcfilters-whats-this-link-text',
'priority' => 2,
- 'filters' => $filters,
+ 'filters' => array_values( $filters ),
'default' =>
ChangesListStringOptionsFilterGroup::NONE,
'isFullCoverage' => false,
'queryCallable' => function (
$specialClassName, $ctx, $dbr, &$tables, &$fields,
@@ -248,7 +248,7 @@
$goodfaithLevels = $stats->getThresholds( 'goodfaith' );
$filters = [];
if ( isset( $goodfaithLevels['likelygood'] ) ) {
- $filters[] = [
+ $filters[ 'likelygood' ] = [
'name' => 'likelygood',
'label' =>
'ores-rcfilters-goodfaith-good-label',
'description' =>
'ores-rcfilters-goodfaith-good-desc',
@@ -260,7 +260,7 @@
];
}
if ( isset( $goodfaithLevels['maybebad'] ) ) {
- $filters[] = [
+ $filters[ 'maybebad' ] = [
'name' => 'maybebad',
'label' =>
'ores-rcfilters-goodfaith-maybebad-label',
'description' =>
'ores-rcfilters-goodfaith-maybebad-desc',
@@ -272,7 +272,7 @@
];
}
if ( isset( $goodfaithLevels['likelybad'] ) ) {
- $filters[] = [
+ $filters[ 'likelybad' ] = [
'name' => 'likelybad',
'label' =>
'ores-rcfilters-goodfaith-bad-label',
'description' =>
'ores-rcfilters-goodfaith-bad-desc',
@@ -284,7 +284,7 @@
];
}
if ( isset( $goodfaithLevels['verylikelybad'] ) ) {
- $filters[] = [
+ $filters[ 'verylikelybad' ] = [
'name' => 'verylikelybad',
'label' =>
'ores-rcfilters-goodfaith-verylikelybad-label',
'description' =>
'ores-rcfilters-goodfaith-verylikelybad-desc',
@@ -306,7 +306,7 @@
'Special:MyLanguage/Help:New_filters_for_edit_review/Quality_and_Intent_Filters',
'whatsThisLinkText' =>
'ores-rcfilters-whats-this-link-text',
'priority' => 1,
- 'filters' => $filters,
+ 'filters' => array_values( $filters ),
'default' =>
ChangesListStringOptionsFilterGroup::NONE,
'isFullCoverage' => false,
'queryCallable' => function (
$specialClassName, $ctx, $dbr, &$tables, &$fields,
--
To view, visit https://gerrit.wikimedia.org/r/351183
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ba11abc9279326b4794a14b8249a3f717f831bd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ORES
Gerrit-Branch: master
Gerrit-Owner: Sbisson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
