Madhuvishy has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/351201 )
Change subject: swap: Add analytics-privatedata-users to allowed user groups for notebook access ...................................................................... swap: Add analytics-privatedata-users to allowed user groups for notebook access Change-Id: I4cbaa1c571592ad50bc6fac4b1cbc03c843166c8 --- M hieradata/role/common/paws_internal/jupyterhub.yaml M modules/jupyterhub/files/jupyterhub_config.py 2 files changed, 3 insertions(+), 1 deletion(-) Approvals: Madhuvishy: Looks good to me, approved jenkins-bot: Verified diff --git a/hieradata/role/common/paws_internal/jupyterhub.yaml b/hieradata/role/common/paws_internal/jupyterhub.yaml index 6103920..5fb55c7 100644 --- a/hieradata/role/common/paws_internal/jupyterhub.yaml +++ b/hieradata/role/common/paws_internal/jupyterhub.yaml @@ -2,6 +2,7 @@ - notebook-roots - researchers - statistics-privatedata-users + - analytics-privatedata-users jupyterhub::web_proxy: http://webproxy.eqiad.wmnet:8080 debdeploy::grains: diff --git a/modules/jupyterhub/files/jupyterhub_config.py b/modules/jupyterhub/files/jupyterhub_config.py index 109ab68..de4cbcd 100644 --- a/modules/jupyterhub/files/jupyterhub_config.py +++ b/modules/jupyterhub/files/jupyterhub_config.py @@ -108,7 +108,8 @@ @gen.coroutine def authenticate(self, handler, data): username = data['username'] - allowed_groups = ['researchers', 'statistics-privatedata-users', 'ops'] + allowed_groups = ['researchers', 'statistics-privatedata-users', + 'analytics-privatedata-users', 'ops'] if not any([ username in grp.getgrnam(group).gr_mem for group in allowed_groups]): -- To view, visit https://gerrit.wikimedia.org/r/351201 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4cbaa1c571592ad50bc6fac4b1cbc03c843166c8 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Madhuvishy <[email protected]> Gerrit-Reviewer: Madhuvishy <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
