jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/351021 )
Change subject: uw.TitleDetailsWidget.test: Don't hardcode English namespace
name
......................................................................
uw.TitleDetailsWidget.test: Don't hardcode English namespace name
This lets the test pass when the wiki content language is not English.
Change-Id: I652a8471ec844124d01f3d4673a33f0348c10e46
---
M tests/qunit/uw.TitleDetailsWidget.test.js
1 file changed, 7 insertions(+), 5 deletions(-)
Approvals:
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/tests/qunit/uw.TitleDetailsWidget.test.js
b/tests/qunit/uw.TitleDetailsWidget.test.js
index fa7d016..c9084c0 100644
--- a/tests/qunit/uw.TitleDetailsWidget.test.js
+++ b/tests/qunit/uw.TitleDetailsWidget.test.js
@@ -1,13 +1,15 @@
( function ( mw, uw, $ ) {
'use strict';
- var makeTitleInFileNSCases = [ {
+ var fileNs, makeTitleInFileNSCases;
+ fileNs = mw.config.get( 'wgFormattedNamespaces' )[ 6 ];
+ makeTitleInFileNSCases = [ {
filename: 'foo.png',
- prefixedText: 'File:Foo.png',
+ prefixedText: fileNs + ':Foo.png',
desc: 'filename without namespace starting with a lower case
letter'
}, {
filename: 'foo_bar-baz.jpg',
- prefixedText: 'File:Foo bar-baz.jpg',
+ prefixedText: fileNs + ':Foo bar-baz.jpg',
desc: 'filename without namespace with space in it'
}, {
filename: 'MediaWiki:foo_bar.jpg',
@@ -15,11 +17,11 @@
desc: 'filename starting with MediaWiki: (colons are
disallowed)'
}, {
filename: 'File:foo_bar.jpg',
- prefixedText: 'File:Foo bar.jpg',
+ prefixedText: fileNs + ':Foo bar.jpg',
desc: 'filename starting with File:'
}, {
filename: 'file:foo_bar.jpg',
- prefixedText: 'File:Foo bar.jpg',
+ prefixedText: fileNs + ':Foo bar.jpg',
desc: 'filename starting with file:'
}, {
filename: 'Foo part 1/2.jpg',
--
To view, visit https://gerrit.wikimedia.org/r/351021
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I652a8471ec844124d01f3d4673a33f0348c10e46
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: master
Gerrit-Owner: Bartosz DziewoĆski <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits