jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/351220 )
Change subject: Hygiene: Don't unnecessarily use loadModuleScript
......................................................................
Hygiene: Don't unnecessarily use loadModuleScript
This is loaded unconditionally
loadModuleScript is only designed to run when a button is clicked
and the user needs feedback. It doesnt apply here
Change-Id: Id8f231f92addf8004b94791ff36af59d86e5b032
---
M resources/skins.minerva.notifications/init.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/skins.minerva.notifications/init.js
b/resources/skins.minerva.notifications/init.js
index ecd33ca..719edbd 100644
--- a/resources/skins.minerva.notifications/init.js
+++ b/resources/skins.minerva.notifications/init.js
@@ -123,7 +123,7 @@
}
// Load the notification filter overlay
- loadModuleScript( 'mobile.notifications.filter.overlay'
).done( function () {
+ mw.loader.using( 'mobile.notifications.filter.overlay'
).done( function () {
var $crossWikiUnreadFilter = $(
'.mw-echo-ui-crossWikiUnreadFilterWidget' ),
$notifReadState = $(
'.mw-echo-ui-notificationsInboxWidget-main-toolbar-readState' ),
NotificationsFilterOverlay = M.require(
'mobile.notifications.filter.overlay/NotificationsFilterOverlay' );
--
To view, visit https://gerrit.wikimedia.org/r/351220
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id8f231f92addf8004b94791ff36af59d86e5b032
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
