Kaldari has submitted this change and it was merged. Change subject: Replacing intval() with casting ......................................................................
Replacing intval() with casting as per http://hakre.wordpress.com/2010/05/13/php-casting-vs-intval/ casting is much much faster. Change-Id: I6b3ef8d6715fd78ac9119cb8448489ba535ea5da --- M cron/updatePageTriageQueue.php M cron/updateUserMetadata.php M includes/ArticleMetadata.php M includes/PageTriage.php M includes/PageTriageUtil.php 5 files changed, 7 insertions(+), 7 deletions(-) Approvals: Kaldari: Verified; Looks good to me, approved jenkins-bot: Checked diff --git a/cron/updatePageTriageQueue.php b/cron/updatePageTriageQueue.php index 7731ab9..0a92c48 100644 --- a/cron/updatePageTriageQueue.php +++ b/cron/updatePageTriageQueue.php @@ -58,7 +58,7 @@ while ( $count === $this->batchSize ) { $count = 0; $startTime = $this->dbr->addQuotes( $this->dbr->timestamp( $startTime ) ); - $startId = intval( $startId ); + $startId = ( int )$startId; // Remove pages older than 30 days, if // 1. the page has been reviewed, or diff --git a/cron/updateUserMetadata.php b/cron/updateUserMetadata.php index 9ca2dc3..cd846c2 100644 --- a/cron/updateUserMetadata.php +++ b/cron/updateUserMetadata.php @@ -64,7 +64,7 @@ while ( $count === $this->batchSize ) { $count = 0; $startTime = $this->dbr->addQuotes( $this->dbr->timestamp( $startTime ) ); - $startId = intval( $startId ); + $startId = ( int )$startId; $res = $this->dbr->select( array( 'pagetriage_page', 'page' ), diff --git a/includes/ArticleMetadata.php b/includes/ArticleMetadata.php index b32b006..814697e 100644 --- a/includes/ArticleMetadata.php +++ b/includes/ArticleMetadata.php @@ -271,7 +271,7 @@ $cleanUp = array(); foreach ( $pageIds as $key => $val ) { - $casted = intval( $val ); + $casted = ( int )$val; if ( $casted ) { if ( isset( $cache[$casted] ) ) { if ( $cache[$casted] ) { diff --git a/includes/PageTriage.php b/includes/PageTriage.php index 3cf7840..37aedf1 100644 --- a/includes/PageTriage.php +++ b/includes/PageTriage.php @@ -23,7 +23,7 @@ * @param $pageId int */ public function __construct( $pageId ) { - $this->mPageId = intval( $pageId ); + $this->mPageId = ( int )$pageId; $this->mLoaded = false; } diff --git a/includes/PageTriageUtil.php b/includes/PageTriageUtil.php index dc8b2ae..cfe6f43 100644 --- a/includes/PageTriageUtil.php +++ b/includes/PageTriageUtil.php @@ -91,7 +91,7 @@ $data = array( 'count' => 0, 'oldest' => '' ); if ( $res ) { - $data['count'] = intval( $res->total ); + $data['count'] = ( int )$res->total; $data['oldest'] = $res->oldest; } @@ -153,7 +153,7 @@ $total = 0; if ( $res ) { - $total = intval( $res->total ); + $total = ( int )$res->total; } // make it expire in 10 minutes @@ -194,7 +194,7 @@ $data = array( 'reviewed_count' => 0 ); if ( $res ) { - $data['reviewed_count'] = intval( $res->reviewed_count ); + $data['reviewed_count'] = ( int )$res->reviewed_count; } // make it expire in 10 minutes -- To view, visit https://gerrit.wikimedia.org/r/44213 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b3ef8d6715fd78ac9119cb8448489ba535ea5da Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/PageTriage Gerrit-Branch: master Gerrit-Owner: Nischayn22 <[email protected]> Gerrit-Reviewer: Alex Monk <[email protected]> Gerrit-Reviewer: Demon <[email protected]> Gerrit-Reviewer: Kaldari <[email protected]> Gerrit-Reviewer: Nikerabbit <[email protected]> Gerrit-Reviewer: Nischayn22 <[email protected]> Gerrit-Reviewer: Parent5446 <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
