Thiemo Mättig (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/351283 )
Change subject: Fix reference because of missed WikibaseIndexField rename
......................................................................
Fix reference because of missed WikibaseIndexField rename
Not horribly because it's just a comment, but should be fixed anyway.
I'm also removing unused uses because it's not really worth a separate
patch.
Change-Id: I76a3b77015f9e452f62ea79c2766881904357de4
---
M src/Search/MediaInfoFieldDefinitions.php
M tests/phpunit/composer/DataModel/Serialization/MediaInfoSerializerTest.php
2 files changed, 4 insertions(+), 6 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseMediaInfo
refs/changes/83/351283/1
diff --git a/src/Search/MediaInfoFieldDefinitions.php
b/src/Search/MediaInfoFieldDefinitions.php
index 2021533..0490f7f 100644
--- a/src/Search/MediaInfoFieldDefinitions.php
+++ b/src/Search/MediaInfoFieldDefinitions.php
@@ -6,6 +6,7 @@
use Wikibase\Repo\Search\Elastic\Fields\FieldDefinitions;
use Wikibase\Repo\Search\Elastic\Fields\LabelsProviderFieldDefinitions;
use Wikibase\Repo\Search\Elastic\Fields\StatementCountField;
+use Wikibase\Repo\Search\Elastic\Fields\WikibaseIndexField;
/**
* @license GPL-2.0+
@@ -23,10 +24,6 @@
*/
private $descriptionsProviderFieldDefinitions;
- /**
- * @param LabelsProviderFieldDefinitions $labelsProviderFieldDefinitions
- * @param DescriptionsProviderFieldDefinitions
$descriptionsProviderFieldDefinitions
- */
public function __construct(
LabelsProviderFieldDefinitions $labelsProviderFieldDefinitions,
DescriptionsProviderFieldDefinitions
$descriptionsProviderFieldDefinitions
@@ -36,7 +33,9 @@
}
/**
- * @return SearchIndexField[]
+ * @see FieldDefinitions::getFields
+ *
+ * @return WikibaseIndexField[]
*/
public function getFields() {
$fields = array_merge(
diff --git
a/tests/phpunit/composer/DataModel/Serialization/MediaInfoSerializerTest.php
b/tests/phpunit/composer/DataModel/Serialization/MediaInfoSerializerTest.php
index 542dd03..5009017 100644
--- a/tests/phpunit/composer/DataModel/Serialization/MediaInfoSerializerTest.php
+++ b/tests/phpunit/composer/DataModel/Serialization/MediaInfoSerializerTest.php
@@ -7,7 +7,6 @@
use Serializers\Serializer;
use Wikibase\DataModel\Entity\Item;
use Wikibase\DataModel\Snak\PropertyNoValueSnak;
-use Wikibase\DataModel\Statement\Statement;
use Wikibase\DataModel\Statement\StatementList;
use Wikibase\DataModel\Term\TermList;
use Wikibase\MediaInfo\DataModel\MediaInfo;
--
To view, visit https://gerrit.wikimedia.org/r/351283
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I76a3b77015f9e452f62ea79c2766881904357de4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseMediaInfo
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
