jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/350814 )
Change subject: Document removeXMLProcInst line in .svgo.yml ...................................................................... Document removeXMLProcInst line in .svgo.yml If your SVG doesn't start with an XML declaration, then it's MIME type will be detected as "text/plain" rather than "image/svg+xml". This is because CSSMin::getMimeType uses the fileinfo extension to detect the MIME type of a file and that extension to defers to libmagic. libmagic's default database[1] currently requires that SVGs contain an XML declaration. 1: https://github.com/threatstack/libmagic/blob/master/magic/Magdir/sgml#L5 Change-Id: Ibacb748fec161f08a2e2d9ca15847da0e3cc8ccd --- M .svgo.yml 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Jhernandez: Looks good to me, approved jenkins-bot: Verified Jdlrobson: Looks good to me, but someone else must approve diff --git a/.svgo.yml b/.svgo.yml index 52ae3ca..dd58499 100644 --- a/.svgo.yml +++ b/.svgo.yml @@ -1,5 +1,12 @@ plugins: + + # If the SVG doesn't start with an XML declaration, then it's MIME type will + # be detected as "text/plain" rather than "image/svg+xml" by libmagic and, + # consequently, MediaWiki's CSSMin CSS minifier. libmagic's default database + # currently requires that SVGs contain an XML declaration + # <https://github.com/threatstack/libmagic/blob/master/magic/Magdir/sgml#L5>. - removeXMLProcInst: false + - cleanupIDs: false - collapseGroups: false - - mergePaths: false \ No newline at end of file + - mergePaths: false -- To view, visit https://gerrit.wikimedia.org/r/350814 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibacb748fec161f08a2e2d9ca15847da0e3cc8ccd Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Phuedx <[email protected]> Gerrit-Reviewer: Jdlrobson <[email protected]> Gerrit-Reviewer: Jhernandez <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
