jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/351294 )
Change subject: Fix default option key for Echo notifications ...................................................................... Fix default option key for Echo notifications The option keys are based notification categories, not type. See https://www.mediawiki.org/w/index.php?oldid=2455600#Conventions Change-Id: Ia7cb9bff990434d031ac89b8354edb38ed33fc22 --- M client/includes/Hooks/EchoNotificationsHandlers.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: jenkins-bot: Verified Thiemo Mättig (WMDE): Looks good to me, approved diff --git a/client/includes/Hooks/EchoNotificationsHandlers.php b/client/includes/Hooks/EchoNotificationsHandlers.php index c193344..50dd0e2 100644 --- a/client/includes/Hooks/EchoNotificationsHandlers.php +++ b/client/includes/Hooks/EchoNotificationsHandlers.php @@ -169,7 +169,7 @@ * @param bool[] &$defaultOptions Array of preference keys and their default values. */ public static function onUserGetDefaultOptions( array &$defaultOptions ) { - $defaultOptions['echo-subscriptions-web-' . self::NOTIFICATION_TYPE] = true; + $defaultOptions['echo-subscriptions-web-wikibase-action'] = true; } /** -- To view, visit https://gerrit.wikimedia.org/r/351294 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7cb9bff990434d031ac89b8354edb38ed33fc22 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Matěj Suchánek <[email protected]> Gerrit-Reviewer: Ladsgroup <[email protected]> Gerrit-Reviewer: Matěj Suchánek <[email protected]> Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
