jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/351248 )
Change subject: Remove CodeMirror specific code
......................................................................
Remove CodeMirror specific code
Seems CodeMirror should not be used with the MobileFrontend extension since
mobile devices should use the simplest editor only.
This code was introduced by I1d5dd5a0896c4f32954d9b948cc21c9406898f45
for a no longer used feature.
Change-Id: I14ad8cbf5710e0e1df886f2c82b6f01f30381acc
---
M includes/MobileFrontend.hooks.php
1 file changed, 0 insertions(+), 5 deletions(-)
Approvals:
jenkins-bot: Verified
Jdlrobson: Looks good to me, approved
diff --git a/includes/MobileFrontend.hooks.php
b/includes/MobileFrontend.hooks.php
index 684857a..820156d 100644
--- a/includes/MobileFrontend.hooks.php
+++ b/includes/MobileFrontend.hooks.php
@@ -435,11 +435,6 @@
if ( $context->shouldDisplayMobileView() ) {
$vars['wgImagesDisabled'] = $context->imagesDisabled();
}
- // add CodeMirror specific things, if it is installed (for
CodeMirror editor)
- if ( class_exists( 'CodeMirrorHooks' ) ) {
- $vars += CodeMirrorHooks::getGlobalVariables(
MobileContext::singleton() );
- $vars['wgMFCodeMirror'] = true;
- }
return true;
}
--
To view, visit https://gerrit.wikimedia.org/r/351248
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I14ad8cbf5710e0e1df886f2c82b6f01f30381acc
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Pastakhov <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
