[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Code lint: Don't shadow native globals (undefined/window)

[Esanders (Code Review)]

Esanders has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/351594 )

Change subject: Code lint: Don't shadow native globals (undefined/window)
......................................................................

Code lint: Don't shadow native globals (undefined/window)

Change-Id: If6fea4599e0bd30fe888558e9988594de8dba40d
---
M modules/box/Map.js
M modules/maplink/maplink.js
M modules/wikivoyage/ControlNearby.js
M modules/wikivoyage/wikivoyage.js
4 files changed, 6 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Kartographer 
refs/changes/94/351594/1

diff --git a/modules/box/Map.js b/modules/box/Map.js
index cd83424..a18e8ec 100644
--- a/modules/box/Map.js
+++ b/modules/box/Map.js
@@ -10,7 +10,7 @@
  * @class Kartographer.Box.MapClass
  * @extends L.Map
  */
-module.Map = ( function ( mw, OpenFullScreenControl, dataLayerOpts, 
ScaleControl, DataManager, topojson, window, undefined ) {
+module.Map = ( function ( mw, OpenFullScreenControl, dataLayerOpts, 
ScaleControl, DataManager, topojson ) {
 
        var scale, urlFormat,
                mapServer = mw.config.get( 'wgKartographerMapServer' ),
@@ -851,8 +851,7 @@
        module.dataLayerOpts,
        module.ScaleControl,
        module.Data,
-       require( 'ext.kartographer.lib.topojson' ),
-       window
+       require( 'ext.kartographer.lib.topojson' )
 ) );
 
 module.map = ( function ( KartographerMap ) {
diff --git a/modules/maplink/maplink.js b/modules/maplink/maplink.js
index 9220886..00d72ca 100644
--- a/modules/maplink/maplink.js
+++ b/modules/maplink/maplink.js
@@ -10,7 +10,7 @@
  * @class Kartographer.Link
  * @singleton
  */
-module.exports = ( function ( $, mw, router, kartolink, undefined ) {
+module.exports = ( function ( $, mw, router, kartolink ) {
 
        /**
         * References the maplinks of the page.
diff --git a/modules/wikivoyage/ControlNearby.js 
b/modules/wikivoyage/ControlNearby.js
index e96bbff..4c77dc8 100644
--- a/modules/wikivoyage/ControlNearby.js
+++ b/modules/wikivoyage/ControlNearby.js
@@ -10,7 +10,7 @@
  * @extends L.Control
  * @private
  */
-module.ControlNearby = ( function ( $, mw, L, wikivoyage, NearbyArticles, 
pruneClusterLib, undefined ) {
+module.ControlNearby = ( function ( $, mw, L, wikivoyage, NearbyArticles, 
pruneClusterLib ) {
 
        var articlePath = mw.config.get( 'wgArticlePath' );
 
diff --git a/modules/wikivoyage/wikivoyage.js b/modules/wikivoyage/wikivoyage.js
index f25f565..e65ea40 100644
--- a/modules/wikivoyage/wikivoyage.js
+++ b/modules/wikivoyage/wikivoyage.js
@@ -6,7 +6,7 @@
  * @class Kartographer.Wikivoyage.wikivoyage
  * @singleton
  */
-module.wikivoyage = ( function ( $, mw, undefined ) {
+module.wikivoyage = ( function ( $, mw ) {
        var tileLayerDefs = {},
                areExternalAllowed,
                windowManager,
@@ -154,4 +154,4 @@
                }
        };
 
-}( jQuery, mediaWiki, module.WVMap ) );
+}( jQuery, mediaWiki ) );

-- 
To view, visit https://gerrit.wikimedia.org/r/351594
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If6fea4599e0bd30fe888558e9988594de8dba40d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Kartographer
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits