jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/351588 )
Change subject: Throw errors, not strings
......................................................................
Throw errors, not strings
Change-Id: I65bad18f2526283ba426aed8ff7da9121f230770
---
M modules/ext.RevisionSlider.SliderView.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
WMDE-Fisch: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ext.RevisionSlider.SliderView.js
b/modules/ext.RevisionSlider.SliderView.js
index 5cdc4bc..c1d9ab0 100644
--- a/modules/ext.RevisionSlider.SliderView.js
+++ b/modules/ext.RevisionSlider.SliderView.js
@@ -441,7 +441,7 @@
}
if ( $oldRevElement.length === 0 &&
$newRevElement.length === 0 ) {
// Note: this is currently caught in init.js
- throw 'RS-revs-not-specified';
+ throw new Error( 'RS-revs-not-specified' );
}
if ( $oldRevElement.length !== 0 ) {
this.pointerOlder.setPosition(
$oldRevElement.data( 'pos' ) );
--
To view, visit https://gerrit.wikimedia.org/r/351588
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I65bad18f2526283ba426aed8ff7da9121f230770
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: WMDE-Fisch <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
