Lucas Werkmeister (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/351633 )
Change subject: Fixed Table-Width Error in QueryExampleDialog
......................................................................
Fixed Table-Width Error in QueryExampleDialog
The Width of the first column in the the QED is determined by its
longest entry. When filtering these entry, or this list contains
only short entries, the right columns (containing the glyphicons
for source and preview) shift to the left, i.e. their colums
"grow". By explicitly setting a column width, this bug is fixed.
Change-Id: I06ff1ffac2ccb66f0e04e9b9dfd4f492c4e3bc85
---
M style.css
M wikibase/queryService/ui/QueryExampleDialog.js
2 files changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/wikidata/query/gui
refs/changes/33/351633/1
diff --git a/style.css b/style.css
index febe25f..84b6e54 100644
--- a/style.css
+++ b/style.css
@@ -85,6 +85,10 @@
width: 160px;
}
+.exampleIcons {
+ width: 20px;
+}
+
iframe.shortUrl {
border: none;
width: 250px;
diff --git a/wikibase/queryService/ui/QueryExampleDialog.js
b/wikibase/queryService/ui/QueryExampleDialog.js
index 5fad8fb..bdac977 100644
--- a/wikibase/queryService/ui/QueryExampleDialog.js
+++ b/wikibase/queryService/ui/QueryExampleDialog.js
@@ -269,8 +269,8 @@
var example = $( '<tr>' );
example.append( $( '<td>' ).append( $link ).append( ' ', $edit
) );
- example.append( $( '<td>' ).append( $preview ) );
- example.append( $( '<td>' ).append( $source ) );
+ example.append( $( '<td class="exampleIcons">' ).append(
$preview ) );
+ example.append( $( '<td class="exampleIcons">' ).append(
$source ) );
example.append( $( '<td>' ).text( tags.join( '|' ) ).hide() );
example.append( $( '<td>' ).text( query ).hide() );
--
To view, visit https://gerrit.wikimedia.org/r/351633
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I06ff1ffac2ccb66f0e04e9b9dfd4f492c4e3bc85
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Lucas Werkmeister (WMDE) <[email protected]>
Gerrit-Reviewer: Fraemisch <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
