jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/350559 )
Change subject: I am not very familiar with Review. In this case method returns
when $step is not an object without setting statebarbodyreview causing some
users not to be able to see review overview. Now, i dont know if this is just
an oversight or there is a reason for
......................................................................
I am not very familiar with Review. In this case method returns when
$step is not an object without setting statebarbodyreview causing some
users not to be able to see review overview.
Now, i dont know if this is just an oversight or there is a reason for
returning without setting statebarbodyreview
If this is a valid bug, it needs to be cherry-picked to REL1_27 and master
Change-Id: If5795f9406ed1350c6cf7cc9f7c3928af40d164c
---
M Review/Review.class.php
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
ItSpiderman: Looks good to me, approved
jenkins-bot: Verified
diff --git a/Review/Review.class.php b/Review/Review.class.php
index 3a15e78..65170a3 100644
--- a/Review/Review.class.php
+++ b/Review/Review.class.php
@@ -1101,6 +1101,8 @@
$step = $oRev->currentStep( $oUser->getId() );
if ( !is_object( $step ) ) {
+ $aBodyViews[ 'statebarbodyreview' ] = $oReviewView;
+
return true;
}
--
To view, visit https://gerrit.wikimedia.org/r/350559
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If5795f9406ed1350c6cf7cc9f7c3928af40d164c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: REL1_27
Gerrit-Owner: Pwirth <[email protected]>
Gerrit-Reviewer: ItSpiderman <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
