Addshore has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/351781 )

Change subject: Fix selectSitesForPage to use getReadConnectionRef
......................................................................

Fix selectSitesForPage to use getReadConnectionRef

This select is made after edits that cause the links
to change for pages (such as creations, moves and deletes)

Prior to Iff20a22f9f2bc7ceefd6defc0ed9a494a6fe62c0 this
used a read connection and the patch accidently changed this
method to using a write connection.

Probably not the cause of the attached bug but could be a factor.

Bug: T164407
Change-Id: Ia1ddc54d800ab1695f0909b81849670ac35e4834
---
M src/CognateStore.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Cognate 
refs/changes/81/351781/1

diff --git a/src/CognateStore.php b/src/CognateStore.php
index 944c264..35a9251 100644
--- a/src/CognateStore.php
+++ b/src/CognateStore.php
@@ -163,7 +163,7 @@
         * @return string[] array of dbnames
         */
        public function selectSitesForPage( LinkTarget $linkTarget ) {
-               $dbr = $this->connectionManager->getWriteConnectionRef();
+               $dbr = $this->connectionManager->getReadConnectionRef();
                $result = $dbr->select(
                        [
                                self::TITLES_TABLE_NAME,

-- 
To view, visit https://gerrit.wikimedia.org/r/351781
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia1ddc54d800ab1695f0909b81849670ac35e4834
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Cognate
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to