Ori.livneh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/52221


Change subject: Fix use of deprecated configs for Extension:RSS
......................................................................

Fix use of deprecated configs for Extension:RSS

If you browse to a page on mediawikiwiki that uses the <rss> tag, you'll find
its content replaced with the following notice:

> Extension:RSS -- Error: The deprecated variable $wgRSSAllowedFeeds has been
> detected. Since RSS version 2.0 this variable has to be replaced by
> $wgRSSUrlWhitelist as described in the manual page Extension:RSS.

This change updates our configuration to set the correct variable. The name is
not the only thing that has changed, though -- setting $wgRSSAllowedFeeds to an
empty array (which is what we configured) would previously allow all feeds,
whereas now they need to be explicitly whitelisted. We'll have to add things
like gerritweb by hand, but it's better than allowing content from anywhere.

Change-Id: I556287a9e5f7993a11130701260a76914b8199d6
---
M wmf-config/CommonSettings.php
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/21/52221/1

diff --git a/wmf-config/CommonSettings.php b/wmf-config/CommonSettings.php
index 4779bff..df3ba96 100644
--- a/wmf-config/CommonSettings.php
+++ b/wmf-config/CommonSettings.php
@@ -1319,7 +1319,11 @@
 if ( $wmgUseRSSExtension ) {
        include( "$IP/extensions/RSS/RSS.php" );
        # $wgRSSProxy = 'url-downloader.wikimedia.org:8080';
-       $wgRSSAllowedFeeds = $wmgRSSAllowedFeeds;
+       if ( defined('EXTENSION_RSS_VERSION') && EXTENSION_RSS_VERSION > 2 ) {
+               $wgRSSUrlWhitelist = $wmgRSSAllowedFeeds;
+       } else {
+               $wgRSSAllowedFeeds = $wmgRSSAllowedFeeds;
+       }
 }
 
 wfProfileOut( "$fname-ext-include2" );

-- 
To view, visit https://gerrit.wikimedia.org/r/52221
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I556287a9e5f7993a11130701260a76914b8199d6
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to