jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/352288 )

Change subject: jquery.ui: Avoid deprecated jQuery.expr[":"]
......................................................................


jquery.ui: Avoid deprecated jQuery.expr[":"]

Compatible with jQuery 1.11 and 3.x, as jQuery.expr.pseudos was
introduced in jQuery 1.8.

Note that this is not blocking jQuery 3 (T124742) since it is
covered by jQuery Migrate. But fixing this makes the edit page less
noisy by default.

Change-Id: I7ffbfd2e55aa7dcc31860eb0117b203e63ca7283
---
M resources/lib/jquery.ui/PATCHES
M resources/lib/jquery.ui/jquery.ui.core.js
M resources/lib/jquery.ui/jquery.ui.widget.js
3 files changed, 10 insertions(+), 2 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/resources/lib/jquery.ui/PATCHES b/resources/lib/jquery.ui/PATCHES
index a8eba94..bcff2ac 100644
--- a/resources/lib/jquery.ui/PATCHES
+++ b/resources/lib/jquery.ui/PATCHES
@@ -1,3 +1,7 @@
+jquery.ui.core.js
+* I7ffbfd2e5 Avoid deprecated jQuery.expr[":"].
+
+
 jquery.ui.draggable.js
 * 71e11de2a3 Fix positioning error with draggable, revert and grid.
              https://phabricator.wikimedia.org/T140965#2944610
@@ -9,6 +13,10 @@
 * 19531f3c23 Add translations in de-AT and de-CH
 
 
+jquery.ui.widget.js
+* I7ffbfd2e5 Avoid deprecated jQuery.expr[":"].
+
+
 themes/smoothness/jquery.ui.theme.css
 * 5e772e39dd Remove dark color from links inside dialogs
              https://phabricator.wikimedia.org/T85857
diff --git a/resources/lib/jquery.ui/jquery.ui.core.js 
b/resources/lib/jquery.ui/jquery.ui.core.js
index 4ef4b76..19f0069 100644
--- a/resources/lib/jquery.ui/jquery.ui.core.js
+++ b/resources/lib/jquery.ui/jquery.ui.core.js
@@ -157,7 +157,7 @@
                }).length;
 }
 
-$.extend( $.expr[ ":" ], {
+$.extend( $.expr.pseudos, {
        data: $.expr.createPseudo ?
                $.expr.createPseudo(function( dataName ) {
                        return function( elem ) {
diff --git a/resources/lib/jquery.ui/jquery.ui.widget.js 
b/resources/lib/jquery.ui/jquery.ui.widget.js
index 067476d..4d84afc 100644
--- a/resources/lib/jquery.ui/jquery.ui.widget.js
+++ b/resources/lib/jquery.ui/jquery.ui.widget.js
@@ -36,7 +36,7 @@
        }
 
        // create selector for plugin
-       $.expr[ ":" ][ fullName.toLowerCase() ] = function( elem ) {
+       $.expr.pseudos[ fullName.toLowerCase() ] = function( elem ) {
                return !!$.data( elem, fullName );
        };
 

-- 
To view, visit https://gerrit.wikimedia.org/r/352288
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7ffbfd2e55aa7dcc31860eb0117b203e63ca7283
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to