jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/352437 )
Change subject: Fix EchoNotificationsHandlersTest failing for the build ...................................................................... Fix EchoNotificationsHandlersTest failing for the build The change I79646f7 broke the Wikidata build, see I2e9e1be and https://integration.wikimedia.org/ci/job/mediawiki-extensions-hhvm-jessie/12670/console for the failure. Bug: T142107 Change-Id: I2ecc50fb51d8320393231ea5b8b4b23eed50c88a --- M client/tests/phpunit/includes/Hooks/EchoNotificationsHandlersTest.php 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Ladsgroup: Looks good to me, approved jenkins-bot: Verified diff --git a/client/tests/phpunit/includes/Hooks/EchoNotificationsHandlersTest.php b/client/tests/phpunit/includes/Hooks/EchoNotificationsHandlersTest.php index 337b814..6b37de7 100644 --- a/client/tests/phpunit/includes/Hooks/EchoNotificationsHandlersTest.php +++ b/client/tests/phpunit/includes/Hooks/EchoNotificationsHandlersTest.php @@ -18,7 +18,7 @@ * @group WikibaseClient * @group Wikibase */ -class EchoNotificationsHandlersTestCase extends MediaWikiTestCase { +class EchoNotificationsHandlersTest extends MediaWikiTestCase { /** * @var RepoLinker @@ -195,9 +195,9 @@ $icons, "Failed asserting that the notification icon is registered to Echo" ); - $this->assertEquals( - [ 'path' => 'Wikibase/client/includes/Hooks/../../resources/images/echoIcon.svg' ], - $icons[$handlers::NOTIFICATION_TYPE], + $this->assertStringEndsWith( + 'Wikibase/client/includes/Hooks/../../resources/images/echoIcon.svg', + $icons[$handlers::NOTIFICATION_TYPE]['path'], "Failed asserting that missing echoIcon setting defaults to Echo's default" ); -- To view, visit https://gerrit.wikimedia.org/r/352437 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ecc50fb51d8320393231ea5b8b4b23eed50c88a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]> Gerrit-Reviewer: Aude <[email protected]> Gerrit-Reviewer: Ladsgroup <[email protected]> Gerrit-Reviewer: Matěj Suchánek <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
