jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/184301 )
Change subject: Use background-image instead of <img> for spinner
......................................................................
Use background-image instead of <img> for spinner
* Background images get embedded.
Change-Id: Iea1fb3db29b1eb8d5bff1b9b07a6c16145b9efc0
---
M modules/jquery.wikiEditor.dialogs.config.js
M modules/jquery.wikiEditor.dialogs.config.less
2 files changed, 9 insertions(+), 8 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/jquery.wikiEditor.dialogs.config.js
b/modules/jquery.wikiEditor.dialogs.config.js
index 66b74ad..eb3f649 100644
--- a/modules/jquery.wikiEditor.dialogs.config.js
+++ b/modules/jquery.wikiEditor.dialogs.config.js
@@ -96,8 +96,7 @@
htmlTemplate: 'dialogInsertLink.html',
init: function () {
- var loadingMsg,
- api = new mw.Api();
+ var api = new mw.Api();
function isExternalLink( s ) {
// The following things
are considered to be external links:
@@ -311,7 +310,6 @@
} );
// Add images to the page
existence widget, which will be shown mutually exclusively to communicate if
// the page exists, does not
exist or the title is invalid (like if it contains a | character)
- loadingMsg = mw.msg(
'wikieditor-toolbar-tool-link-int-target-status-loading' );
$(
'#wikieditor-toolbar-link-int-target-status' )
.append( $( '<div>' )
.attr( 'id',
'wikieditor-toolbar-link-int-target-status-exists' )
@@ -331,11 +329,7 @@
)
.append( $( '<div>' )
.attr( 'id',
'wikieditor-toolbar-link-int-target-status-loading' )
- .append( $(
'<img>' ).attr( {
- src:
$.wikiEditor.imgPath + 'dialogs/loading-small.gif',
- alt:
loadingMsg,
- title:
loadingMsg
- } ) )
+ .attr( 'title',
mw.msg( 'wikieditor-toolbar-tool-link-int-target-status-loading' ) )
)
.append( $( '<div>' )
.attr( 'id',
'wikieditor-toolbar-link-int-target-status-disambig' )
diff --git a/modules/jquery.wikiEditor.dialogs.config.less
b/modules/jquery.wikiEditor.dialogs.config.less
index 311da5c..d98aee2 100644
--- a/modules/jquery.wikiEditor.dialogs.config.less
+++ b/modules/jquery.wikiEditor.dialogs.config.less
@@ -93,6 +93,7 @@
#wikieditor-toolbar-link-int-target-status-notexists,
#wikieditor-toolbar-link-int-target-status-invalid,
#wikieditor-toolbar-link-int-target-status-external,
+#wikieditor-toolbar-link-int-target-status-loading,
#wikieditor-toolbar-link-int-target-status-disambig {
padding-left: 30px;
background-position: 0 50%;
@@ -119,6 +120,12 @@
background-position: left;
}
+#wikieditor-toolbar-link-int-target-status-loading {
+ .background-image('images/dialogs/loading-small.gif');
+ background-position: right;
+ height: 18px;
+}
+
#wikieditor-toolbar-link-int-target-status-disambig {
.background-image('images/dialogs/insert-disambiguation.png');
background-position: left;
--
To view, visit https://gerrit.wikimedia.org/r/184301
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iea1fb3db29b1eb8d5bff1b9b07a6c16145b9efc0
Gerrit-PatchSet: 9
Gerrit-Project: mediawiki/extensions/WikiEditor
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader <[email protected]>
Gerrit-Reviewer: Aklapper <[email protected]>
Gerrit-Reviewer: Fomafix <[email protected]>
Gerrit-Reviewer: GOIII <[email protected]>
Gerrit-Reviewer: Gerrit Patch Uploader <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Paladox <[email protected]>
Gerrit-Reviewer: TTO <[email protected]>
Gerrit-Reviewer: TheDJ <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
