jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/352355 )
Change subject: Add PHPCS rule set
......................................................................
Add PHPCS rule set
I did not started fixing things because there are way to many. To be
done in later patch sets.
Change-Id: Ia61bea6c1bc7816538ae1b18ed9a15ecf28409c4
---
M composer.json
A phpcs.xml
2 files changed, 48 insertions(+), 3 deletions(-)
Approvals:
Addshore: Looks good to me, approved
Lucas Werkmeister (WMDE): Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/composer.json b/composer.json
index 6001924..6281d5d 100644
--- a/composer.json
+++ b/composer.json
@@ -25,10 +25,11 @@
"wikibase/data-model-services": "~2.0|~3.0"
},
"require-dev": {
+ "jakub-onderka/php-console-highlighter": "0.3.2",
+ "jakub-onderka/php-parallel-lint": "0.9.2",
"phpunit/phpunit": "~3.7,>=3.7.37",
"satooshi/php-coveralls": "dev-master",
- "jakub-onderka/php-parallel-lint": "0.9.2",
- "jakub-onderka/php-console-highlighter": "0.3.2"
+ "wikibase/wikibase-codesniffer": "^0.1.0"
},
"autoload": {
"psr-4": {
@@ -44,7 +45,9 @@
},
"scripts": {
"test": [
- "parallel-lint . --exclude vendor"
+ "@validate --no-interaction",
+ "parallel-lint . --exclude vendor",
+ "phpcs -p -s"
]
}
}
diff --git a/phpcs.xml b/phpcs.xml
new file mode 100644
index 0000000..ce061c4
--- /dev/null
+++ b/phpcs.xml
@@ -0,0 +1,42 @@
+<?xml version="1.0"?>
+<ruleset name="Wikibase">
+ <rule ref="vendor/wikibase/wikibase-codesniffer/Wikibase">
+ <!-- FIXME: The following should all be fixed. -->
+ <exclude name="Generic.Arrays.DisallowLongArraySyntax" />
+ <exclude
name="Generic.Functions.OpeningFunctionBraceKernighanRitchie" />
+ <exclude name="Generic.WhiteSpace.DisallowSpaceIndent" />
+ <exclude
name="MediaWiki.ControlStructures.AssignmentInControlStructures" />
+ <exclude name="MediaWiki.ControlStructures.IfElseStructure" />
+ <exclude name="MediaWiki.WhiteSpace.SpaceAfterControlStructure"
/>
+ <exclude name="MediaWiki.WhiteSpace.SpaceyParenthesis" />
+ <exclude name="PSR1.Classes.ClassDeclaration" />
+ <exclude name="PSR2.Methods.MethodDeclaration" />
+ <exclude name="Squiz.ControlStructures.ControlSignature" />
+ <exclude name="Squiz.Scope.MethodScope" />
+ <exclude name="Squiz.WhiteSpace.FunctionSpacing" />
+ <exclude name="Squiz.WhiteSpace.ScopeClosingBrace" />
+ </rule>
+
+ <!-- Exceptions -->
+
+ <rule ref="Generic.Files.LineLength">
+ <properties>
+ <!-- FIXME: Should be lowered to at least 140. -->
+ <property name="lineLimit" value="168" />
+ <property name="absoluteLineLimit" value="168" />
+ </properties>
+ </rule>
+
+ <!-- Additions -->
+
+ <!-- Metrics are intentionally not part of the base Wikibase
CodeSniffer rule set. -->
+ <rule ref="Generic.Metrics.CyclomaticComplexity">
+ <exclude-pattern>TimeValueComparer</exclude-pattern>
+ </rule>
+ <rule ref="Generic.Metrics.NestingLevel" />
+
+ <!-- TODO: Move to the Wikibase CodeSniffer library. -->
+ <rule ref="Squiz.WhiteSpace.CastSpacing" />
+
+ <file>.</file>
+</ruleset>
--
To view, visit https://gerrit.wikimedia.org/r/352355
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia61bea6c1bc7816538ae1b18ed9a15ecf28409c4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityExternalValidation
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: Lucas Werkmeister (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
