Aaron Schulz has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/352744 )
Change subject: Avoid DB master use on GET in SpecialExportTranslations
......................................................................
Avoid DB master use on GET in SpecialExportTranslations
Change-Id: I50fd9f8cfd2313d076e66e5ec51073aa0c8e2030
---
M messagegroups/WikiPageMessageGroup.php
1 file changed, 11 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate
refs/changes/44/352744/1
diff --git a/messagegroups/WikiPageMessageGroup.php
b/messagegroups/WikiPageMessageGroup.php
index d36d80f..a415275 100644
--- a/messagegroups/WikiPageMessageGroup.php
+++ b/messagegroups/WikiPageMessageGroup.php
@@ -12,7 +12,7 @@
* Wraps the translatable page sections into a message group.
* @ingroup PageTranslation MessageGroup
*/
-class WikiPageMessageGroup extends WikiMessageGroup {
+class WikiPageMessageGroup extends WikiMessageGroup implements IDBAccessObject
{
/**
* @var Title|string
*/
@@ -108,9 +108,10 @@
*
* @param string $key Message key
* @param string $code Language code
+ * @param integer $flags READ_* class constant bitfield
* @return string|null Stored translation or null.
*/
- public function getMessage( $key, $code ) {
+ public function getMessage( $key, $code, $flags = 0 ) {
if ( $this->isSourceLanguage( $code ) ) {
$stuff = $this->load( $code );
@@ -123,10 +124,14 @@
}
$title = Title::makeTitleSafe( $this->getNamespace(),
"$key/$code" );
- $flags = PageTranslationHooks::$renderingContext
- ? Revision::READ_NORMAL // bug T95753
- : Revision::READ_LATEST;
- $rev = Revision::newFromTitle( $title, false, $flags );
+ if ( PageTranslationHooks::$renderingContext ) {
+ $revFlags = Revision::READ_NORMAL; // bug T95753
+ } else {
+ $revFlags = ( $flags & self::READ_LATEST ) ==
self::READ_LATEST
+ ? Revision::READ_LATEST
+ : Revision::READ_NORMAL;
+ }
+ $rev = Revision::newFromTitle( $title, false, $revFlags );
if ( !$rev ) {
return null;
--
To view, visit https://gerrit.wikimedia.org/r/352744
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I50fd9f8cfd2313d076e66e5ec51073aa0c8e2030
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
