Dbrant has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/352859 )
Change subject: Trigger saving/unsaving of page upon toggle.
......................................................................
Trigger saving/unsaving of page upon toggle.
The user interaction of toggling the saved state of a page wasn't actually
kicking off the sync service to update the page's state in the database
and on disk.
Technically the service will still be kicked off the next time the
activity is launched, but this patch makes it immediate.
Bug: T164585
Change-Id: I0bbb61e3d3ff04e8b9501c01cbeae2dfbc7d2124
---
M app/src/main/java/org/wikipedia/readinglist/ReadingListFragment.java
M app/src/main/java/org/wikipedia/readinglist/sync/ReadingListSynchronizer.java
2 files changed, 6 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/59/352859/1
diff --git
a/app/src/main/java/org/wikipedia/readinglist/ReadingListFragment.java
b/app/src/main/java/org/wikipedia/readinglist/ReadingListFragment.java
index 3d90bb2..b40fe2c 100644
--- a/app/src/main/java/org/wikipedia/readinglist/ReadingListFragment.java
+++ b/app/src/main/java/org/wikipedia/readinglist/ReadingListFragment.java
@@ -425,6 +425,7 @@
? R.string.reading_list_article_offline_message
: R.string.reading_list_article_not_offline_message);
adapter.notifyDataSetChanged();
+ ReadingListSynchronizer.instance().syncSavedPages();
}
}
diff --git
a/app/src/main/java/org/wikipedia/readinglist/sync/ReadingListSynchronizer.java
b/app/src/main/java/org/wikipedia/readinglist/sync/ReadingListSynchronizer.java
index cfd5ea4..9f8f081 100644
---
a/app/src/main/java/org/wikipedia/readinglist/sync/ReadingListSynchronizer.java
+++
b/app/src/main/java/org/wikipedia/readinglist/sync/ReadingListSynchronizer.java
@@ -54,14 +54,13 @@
}
public void sync() {
+ syncSavedPages();
// TODO: remove when ready for beta/production
if (!ReleaseUtil.isPreBetaRelease()) {
- syncSavedPages();
return;
}
if (!User.isLoggedIn()) {
L.d("Not logged in, so skipping sync of reading lists.");
- syncSavedPages();
return;
}
CallbackTask.execute(new CallbackTask.Task<Void>() {
@@ -99,7 +98,6 @@
L.d("Local and remote reading lists are in sync.");
}
}
- syncSavedPages();
} catch (IOException e) {
e.printStackTrace();
@@ -107,6 +105,10 @@
return null;
}
}, null);
+ }
+
+ public void syncSavedPages() {
+ WikipediaApp.getInstance().startService(new
Intent(WikipediaApp.getInstance(), SavedPageSyncService.class));
}
private class SyncRunnable implements Runnable {
@@ -246,9 +248,5 @@
private static RemoteReadingLists makeRemoteReadingLists() {
List<ReadingList> lists =
ReadingListData.instance().queryMruLists(null);
return new RemoteReadingLists(Prefs.getReadingListSyncRev(), lists);
- }
-
- private void syncSavedPages() {
- WikipediaApp.getInstance().startService(new
Intent(WikipediaApp.getInstance(), SavedPageSyncService.class));
}
}
--
To view, visit https://gerrit.wikimedia.org/r/352859
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0bbb61e3d3ff04e8b9501c01cbeae2dfbc7d2124
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
