Bearloga has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/352866 )
Change subject: Update results tracking on SERPs
......................................................................
Update results tracking on SERPs
- Cross-wiki results:
- Detects when cross-wiki results have been returned
- Tracks which results were shown and in what order
- Same-wiki results:
- Changes how we count hits returned (using recently
added data attribute)
- Tracks offset (can be useful for detecting engagement)
Bug: T164854
Change-Id: I984b0aeaeb01cf58ede3d019943a2eab86077c90
---
M modules/ext.wikimediaEvents.searchSatisfaction.js
1 file changed, 10 insertions(+), 4 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaEvents
refs/changes/66/352866/1
diff --git a/modules/ext.wikimediaEvents.searchSatisfaction.js
b/modules/ext.wikimediaEvents.searchSatisfaction.js
index 4628343..6e4cc40 100644
--- a/modules/ext.wikimediaEvents.searchSatisfaction.js
+++ b/modules/ext.wikimediaEvents.searchSatisfaction.js
@@ -603,7 +603,7 @@
function setupSearchTest( session ) {
var params,
logEvent = genLogEventFn( 'fulltext', session ),
- iwResultSet;
+ serpExtras, iwResultSet;
if ( isSearchResultPage ) {
// When a new search is performed reset the session
lifetime.
@@ -671,11 +671,15 @@
params = {
query: mw.config.get( 'searchTerm' ),
- hitsReturned: $( '.mw-search-result-heading'
).length
+ hitsReturned: $( '.results-info' ).data(
'mw-num-results-total' )
+ };
+
+ serpExtras = {
+ offset: $( '.results-info' ).data(
'mw-num-results-offset' )
};
// Track which sister wiki results were shown in the
sidebar and in what order
- if ( session.has( 'subTest' ) ) {
+ if ( $( '#mw-interwiki-results > .iw-results' ).length
) {
iwResultSet = [];
$( 'li.iw-resultset' ).each( function () {
iwResultSet.push( {
@@ -683,9 +687,11 @@
position: $( this ).data(
'iw-resultset-pos' )
} );
} );
- params.extraParams = JSON.stringify(
iwResultSet );
+ serpExtras.iw = iwResultSet;
}
+ params.extraParams = JSON.stringify( serpExtras );
+
// Track what did you mean suggestions were displayed
on the page
if ( $( '#mw-search-DYM-suggestion' ).length ) {
params.didYouMeanVisible = 'yes';
--
To view, visit https://gerrit.wikimedia.org/r/352866
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I984b0aeaeb01cf58ede3d019943a2eab86077c90
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: master
Gerrit-Owner: Bearloga <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
