BearND has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/353009 )

Change subject: Hygiene: fix definition test to a specific revision
......................................................................

Hygiene: fix definition test to a specific revision

The content of the 'cat' page on Wiktionary has changed, which
invalidated the test.

Change-Id: If49b4a3aba7b3234b81fec9c544c359585e10c46
---
M test/features/definition/definition.js
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps 
refs/changes/09/353009/1

diff --git a/test/features/definition/definition.js 
b/test/features/definition/definition.js
index 415f8fe..35e8164 100644
--- a/test/features/definition/definition.js
+++ b/test/features/definition/definition.js
@@ -16,7 +16,8 @@
     });
 
     it('en \'cat\' request should have expected structure and content', () => {
-        return preq.get({ uri: 
`${server.config.uri}en.wiktionary.org/v1/page/definition/cat` })
+        return preq.get(
+            { uri: 
`${server.config.uri}en.wiktionary.org/v1/page/definition/cat/42803194` })
             .then((res) => {
                 const en = res.body.en;
                 const bodytext = JSON.stringify(res.body);
@@ -25,7 +26,7 @@
                 assert.ok(bodytext.indexOf('defdate') === -1);
                 assert.deepEqual(res.status, 200);
                 assert.notDeepEqual(en, undefined);
-                assert.ok(en.length === 8);
+                assert.equal(en.length, 8, JSON.stringify(en, null, 2));
                 for (let i = 0; i < en.length; i++) {
                     assert.notDeepEqual(en[i].partOfSpeech, undefined);
                     assert.notDeepEqual(en[i].definitions, undefined);

-- 
To view, visit https://gerrit.wikimedia.org/r/353009
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If49b4a3aba7b3234b81fec9c544c359585e10c46
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: BearND <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to