Thiemo Mättig (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/353024 )
Change subject: Change problematic <h4> headline in popup into <strong>
......................................................................
Change problematic <h4> headline in popup into <strong>
Semantically it is of not much value to have this headline marked as
one. This is just the title of the popup, not much more. What's more
important are the actual headlines of the individual reports.
This patch does have a bunch of implications:
* This makes Ib68a828 obsolete. No need to remove margin/padding any
more, because the <strong> does not have any.
* This makes Iec65d11 obsolete. No need to move the [x] around any more.
* This also reverts 5caaff23, and makes the revert If89accc obsolete.
Change-Id: I08e1fe23473d5a0966f542031664dd7424f9bb1c
---
M docs/user.js
1 file changed, 3 insertions(+), 3 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseQualityConstraints
refs/changes/24/353024/1
diff --git a/docs/user.js b/docs/user.js
index c9dfccb..2a84e2e 100644
--- a/docs/user.js
+++ b/docs/user.js
@@ -11,7 +11,7 @@
icon: 'alert',
iconTitle: mw.message( 'wbqc-potentialissues-long'
).text(),
label: reports.length > 1 ? reports.length.toString() :
'',
- framed: true,
+ framed: false,
popup: {
$content: new OO.ui.StackLayout( {
items: reports,
@@ -22,7 +22,7 @@
width: 400,
padded: true,
head: true,
- label: $( '<h4>' ).text( mw.message(
'wbqc-potentialissues-short' ).text() )
+ label: $( '<strong>' ).text( mw.message(
'wbqc-potentialissues-short' ).text() )
}
} );
@@ -42,7 +42,7 @@
$report = $( '<div>' ).addClass( 'wbqc-report' );
$report.css( 'border-top', '1px solid #eaecf0' ); //
TODO move to CSS on .wbqc-report class
$report.append(
- $( '<h5>' ).text( result.constraint.type )
+ $( '<h4>' ).text( result.constraint.type )
);
if ( result[ 'message-html' ] ) {
$report.append(
--
To view, visit https://gerrit.wikimedia.org/r/353024
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I08e1fe23473d5a0966f542031664dd7424f9bb1c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
