jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/352750 )
Change subject: Show browser, version and os version where availible ...................................................................... Show browser, version and os version where availible It's been hard to track down exact browser versions on WebPageTest and it is fixed now upstream. See: https://github.com/WPO-Foundation/webpagetest/issues/708 Bug: T144268 Change-Id: I7391b36f161906bf5542ff7cd610e55918803c13 --- M lib/index.js 1 file changed, 5 insertions(+), 7 deletions(-) Approvals: Krinkle: Looks good to me, approved jenkins-bot: Verified diff --git a/lib/index.js b/lib/index.js index 9b202a3..2c9b624 100644 --- a/lib/index.js +++ b/lib/index.js @@ -79,14 +79,12 @@ const collectedMetrics = collectMetrics.collect( data, argv ); const reporter = require( './reporter' ).get( argv.reporter ); - // log browser and version if it's availible + // there's a lot different naming if ( data.data.median && data.data.median.firstView ) { - const browserName = data.data.median.firstView.browser_name; - const browserVersion = data.data.median.firstView.browser_version; - // for some browsers the name and version is not availible - if ( browserName && browserVersion ) { - console.log( 'Tested using ' + browserName + ' ' + browserVersion ); - } + const browserName = data.data.median.firstView.browser_name || wptOptions.location; + const browserVersion = data.data.median.firstView.browser_version || 'unknown'; + const osVersion = data.data.median.firstView.os_version || 'unknown'; + console.log( 'Tested using ' + browserName + ' ' + browserVersion + ' on ' + osVersion ); } reporter.report( collectedMetrics, argv ); -- To view, visit https://gerrit.wikimedia.org/r/352750 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7391b36f161906bf5542ff7cd610e55918803c13 Gerrit-PatchSet: 3 Gerrit-Project: performance/WebPageTest Gerrit-Branch: master Gerrit-Owner: Phedenskog <[email protected]> Gerrit-Reviewer: Gilles <[email protected]> Gerrit-Reviewer: Krinkle <[email protected]> Gerrit-Reviewer: Phedenskog <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
