jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/353330 )
Change subject: VisualDiff: Bring in close dialog fix from downstream
......................................................................
VisualDiff: Bring in close dialog fix from downstream
Change-Id: I075692c1f5b0e82cdca0e969df1015a41d417283
---
M src/ui/dialogs/ve.ui.DiffDialog.js
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/src/ui/dialogs/ve.ui.DiffDialog.js
b/src/ui/dialogs/ve.ui.DiffDialog.js
index f012c70..4710d3d 100644
--- a/src/ui/dialogs/ve.ui.DiffDialog.js
+++ b/src/ui/dialogs/ve.ui.DiffDialog.js
@@ -99,8 +99,10 @@
var dialog = this;
setTimeout( function () {
dialog.withoutSizeTransitions( function () {
- dialog.diffElement.positionDescriptions();
- dialog.updateSize();
+ if ( dialog.diffElement && dialog.isVisible() ) {
+ dialog.diffElement.positionDescriptions();
+ dialog.updateSize();
+ }
} );
}, OO.ui.theme.getDialogTransitionDuration() );
};
--
To view, visit https://gerrit.wikimedia.org/r/353330
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I075692c1f5b0e82cdca0e969df1015a41d417283
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
