Ejegg has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/353482 )

Change subject: Don't crash error form on missing keys
......................................................................

Don't crash error form on missing keys

Change-Id: I4218a9a894665425d3293c43bc33cd8e3df41033
---
M gateway_forms/MustacheErrorForm.php
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface 
refs/changes/82/353482/1

diff --git a/gateway_forms/MustacheErrorForm.php 
b/gateway_forms/MustacheErrorForm.php
index 434f9b3..b46ac53 100644
--- a/gateway_forms/MustacheErrorForm.php
+++ b/gateway_forms/MustacheErrorForm.php
@@ -37,7 +37,9 @@
                );
                if ( !$this->gateway->session_hasDonorData() ) {
                        foreach ( DonationData::getRetryFields() as $field ) {
-                               $params[$field] = $data[$field];
+                               if ( isset( $data[$field] ) ) {
+                                       $params[$field] = $data[$field];
+                               }
                        }
                }
                $data['ffname_retry'] = 
GatewayFormChooser::buildPaymentsFormURL( $back_form, $params ) ;

-- 
To view, visit https://gerrit.wikimedia.org/r/353482
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4218a9a894665425d3293c43bc33cd8e3df41033
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Ejegg <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to