jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/353044 )
Change subject: Clear interaction after an event for it is logged in EL ...................................................................... Clear interaction after an event for it is logged in EL Given that interactions end up with an event logged, there shouldn't be a reason to keep an interaction active after it's corresponding final event has been logged. See Tbayer's state graph. This patch removes the current interaction if an event with that token is logged, effectively finalizing it and making it impossible for the token to be reused from the state tree again. Additional changes: * Pass the logged event with the action EVENT_LOGGED so that the reducer can determine if it needs to do anything else. * Since the interaction is removed, when undefined, guard against actions that use state.interaction freely. (Only allow BOOT, LINK_PREVIEW, and EVENT_LOGGED) Bug: T161769 Bug: T163198 Change-Id: I99fd5716dc17da32929b6e8ae4aa164f9d84c387 --- M resources/dist/index.js M resources/dist/index.js.map M src/actions.js M src/changeListeners/eventLogging.js M src/reducers/eventLogging.js M tests/node-qunit/changeListeners/eventLogging.test.js M tests/node-qunit/reducers/eventLogging.test.js 7 files changed, 73 insertions(+), 10 deletions(-) Approvals: jenkins-bot: Verified Phuedx: Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/353044 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99fd5716dc17da32929b6e8ae4aa164f9d84c387 Gerrit-PatchSet: 8 Gerrit-Project: mediawiki/extensions/Popups Gerrit-Branch: master Gerrit-Owner: Jhernandez <[email protected]> Gerrit-Reviewer: Jdlrobson <[email protected]> Gerrit-Reviewer: Jhernandez <[email protected]> Gerrit-Reviewer: Phuedx <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
