Volans has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/353332 )

Change subject: interface: remove unused definition ::offload
......................................................................


interface: remove unused definition ::offload

Since I68acf28e70f7aca5f98525c8faef41aa76f5ac83 was merged this module
doesn't seem to be used anymore.

Bug: T163196
Change-Id: I619ba6e51f5d2f484a60f27d10b47491f3e721cf
---
D modules/interface/manifests/offload.pp
1 file changed, 0 insertions(+), 34 deletions(-)

Approvals:
  jenkins-bot: Verified
  Volans: Looks good to me, approved



diff --git a/modules/interface/manifests/offload.pp 
b/modules/interface/manifests/offload.pp
deleted file mode 100644
index 67320eb..0000000
--- a/modules/interface/manifests/offload.pp
+++ /dev/null
@@ -1,34 +0,0 @@
-# Definition: interface::offload
-#
-# Sets interface offload parameters (with ethtool)
-#
-# Parameters:
-# - $interface:
-#   The network interface to operate on
-# - $setting:
-#   The (abbreviated) offload setting, e.g. 'gro'
-# - $value:
-#   The value (on/off)
-define interface::offload($setting, $value, $interface='eth0')  {
-    # Set in /etc/network/interfaces
-    interface::setting { $title: interface => $interface, setting => 
"offload-${setting}", value => $value }
-
-    # And make sure it's always active
-    $long_param = $setting ? {
-        'rx'  => 'rx-checksumming',
-        'tx'  => 'tx-checksumming',
-        'sg'  => 'scatter-gather',
-        'tso' => 'tcp-segmentation-offload',
-        'ufo' => 'udp-fragmentation-offload',
-        'gso' => 'generic-segmentation-offload',
-        'gro' => 'generic-receive-offload',
-        'lro' => 'large-receive-offload',
-    }
-
-    exec { "ethtool ${interface} -K ${setting} ${value}":
-        path    => '/usr/bin:/usr/sbin:/bin:/sbin',
-        command => "ethtool -K ${interface} ${setting} ${value}",
-        unless  => "test $(ethtool -k ${interface} | awk '/${long_param}:/ { 
print \$2 }') = '${value}'",
-        require => Package['ethtool'],
-    }
-}

-- 
To view, visit https://gerrit.wikimedia.org/r/353332
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I619ba6e51f5d2f484a60f27d10b47491f3e721cf
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Volans <[email protected]>
Gerrit-Reviewer: BBlack <[email protected]>
Gerrit-Reviewer: Faidon Liambotis <[email protected]>
Gerrit-Reviewer: Volans <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to