jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/354638 )
Change subject: Fix callout positioning logic ...................................................................... Fix callout positioning logic Follow-up to 1d395d49660e340df6ecd120b91bbb55947c4419. We were measuring the wrong $window, which happened to work right most of the time but wasn't correct. Change-Id: I50f91623b304f43be58ebac844d507757f56db45 --- M resources/js/ext.uls.interface.js 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: jenkins-bot: Verified Nikerabbit: Looks good to me, approved diff --git a/resources/js/ext.uls.interface.js b/resources/js/ext.uls.interface.js index 0dfe1ec..7fe90f5 100644 --- a/resources/js/ext.uls.interface.js +++ b/resources/js/ext.uls.interface.js @@ -351,7 +351,7 @@ caretRadius = parseInt( $caretBefore.css( 'border-top-width' ), 10 ); - if ( ulsTriggerOffset.left > ( this.$window.width() - caretRadius ) / 2 ) { + if ( ulsTriggerOffset.left > $( window ).width() / 2 ) { this.left = ulsTriggerOffset.left - this.$window.width() - caretRadius; $caretWrapper.addClass( 'caret-right' ); caretPosition = $caretBefore.position(); -- To view, visit https://gerrit.wikimedia.org/r/354638 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50f91623b304f43be58ebac844d507757f56db45 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Bartosz DziewoĆski <matma....@gmail.com> Gerrit-Reviewer: Nikerabbit <niklas.laxst...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits