Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/354658 )
Change subject: Fix instantly closing progress bars in jQuery 3
......................................................................
Fix instantly closing progress bars in jQuery 3
Change-Id: I6c2e507916e7c78181cdf0986856b0934a7759d2
---
M src/ui/dialogs/ve.ui.ProgressDialog.js
M src/ui/ve.ui.Surface.js
2 files changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/58/354658/1
diff --git a/src/ui/dialogs/ve.ui.ProgressDialog.js
b/src/ui/dialogs/ve.ui.ProgressDialog.js
index 6b29ecb..af0d0a0 100644
--- a/src/ui/dialogs/ve.ui.ProgressDialog.js
+++ b/src/ui/dialogs/ve.ui.ProgressDialog.js
@@ -128,7 +128,9 @@
ve.ui.ProgressDialog.prototype.progressComplete = function ( $row, failed ) {
this.inProgress--;
if ( !this.inProgress ) {
- this.close();
+ // Don't try to close while opening
+ // TODO: This should be fixed upstream.
+ this.getManager().opening.then( this.close.bind( this ) );
}
if ( failed ) {
$row.remove();
diff --git a/src/ui/ve.ui.Surface.js b/src/ui/ve.ui.Surface.js
index 4c89bee..eaa2926 100644
--- a/src/ui/ve.ui.Surface.js
+++ b/src/ui/ve.ui.Surface.js
@@ -738,6 +738,9 @@
return progressBarDeferred.promise();
};
+/**
+ * Show all current progress bars
+ */
ve.ui.Surface.prototype.showProgress = function () {
var dialogs = this.dialogs,
progresses = this.progresses;
--
To view, visit https://gerrit.wikimedia.org/r/354658
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6c2e507916e7c78181cdf0986856b0934a7759d2
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
