jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/353841 )
Change subject: Remove duplicate "Message group" title
......................................................................
Remove duplicate "Message group" title
Bug: T165241
Change-Id: I480e28e0f5c3b6469f4aff35cdb62de9ed73de8f
---
M Resources.php
M resources/css/ext.translate.groupselector.css
M resources/js/ext.translate.groupselector.js
3 files changed, 3 insertions(+), 24 deletions(-)
Approvals:
TerraCodes: Looks good to me, but someone else must approve
jenkins-bot: Verified
Nikerabbit: Looks good to me, approved
diff --git a/Resources.php b/Resources.php
index 4dbd857..7f0bfbf 100644
--- a/Resources.php
+++ b/Resources.php
@@ -132,7 +132,6 @@
'mediawiki.jqueryMsg',
],
'messages' => [
- 'translate-msggroupselector-projects',
'translate-msggroupselector-search-all',
'translate-msggroupselector-search-placeholder',
'translate-msggroupselector-search-recent',
diff --git a/resources/css/ext.translate.groupselector.css
b/resources/css/ext.translate.groupselector.css
index 7f55924..790120f 100644
--- a/resources/css/ext.translate.groupselector.css
+++ b/resources/css/ext.translate.groupselector.css
@@ -51,19 +51,9 @@
content: none;
}
-.grid .row .tux-groupselector__title {
- border: 0;
- color: #555;
- font-size: 14pt;
- font-weight: normal;
- line-height: 1.25em;
- padding: 5px 0 0 10px; /* grid override */
- margin: 0;
-}
-
.tux-groupselector__filter {
height: 30px;
- border-bottom: solid 1px #c9c9c9;
+ padding-top: 10px;
}
.tux-groupselector__filter__search__input {
diff --git a/resources/js/ext.translate.groupselector.js
b/resources/js/ext.translate.groupselector.js
index 43a14b9..7469f2d 100644
--- a/resources/js/ext.translate.groupselector.js
+++ b/resources/js/ext.translate.groupselector.js
@@ -56,8 +56,7 @@
* Prepare the selector menu rendering
*/
prepareSelectorMenu: function () {
- var $groupTitle,
- $listFilters,
+ var $listFilters,
$listFiltersGroup,
$search,
$searchIcon,
@@ -66,15 +65,6 @@
this.$menu = $( '<div>' )
.addClass( 'tux-groupselector' )
.addClass( 'grid' );
-
- $groupTitle = $( '<div>' )
- .addClass( 'row' )
- .append(
- $( '<h3>' )
- .addClass(
'tux-groupselector__title' )
- .addClass( 'ten columns' )
- .text( mw.msg(
'translate-msggroupselector-projects' ) )
- );
$searchIcon = $( '<div>' )
.addClass( 'two columns
tux-groupselector__filter__search__icon' );
@@ -125,7 +115,7 @@
this.$loader = $( '<div>' )
.addClass( 'tux-loading-indicator
tux-loading-indicator--centered' );
- this.$menu.append( $groupTitle, $listFiltersGroup,
this.$loader, this.$list );
+ this.$menu.append( $listFiltersGroup, this.$loader,
this.$list );
$( 'body' ).append( this.$menu );
},
--
To view, visit https://gerrit.wikimedia.org/r/353841
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I480e28e0f5c3b6469f4aff35cdb62de9ed73de8f
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: TerraCodes <terraco...@outlook.com>
Gerrit-Reviewer: Nikerabbit <niklas.laxst...@gmail.com>
Gerrit-Reviewer: TerraCodes <terraco...@outlook.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
