Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/354662 )
Change subject: Revert "Use progress bar instead of text when initializing the
slider"
......................................................................
Revert "Use progress bar instead of text when initializing the slider"
This reverts commit 686bc5df9a7db38e321e67de49069b16ec84e9da.
Change-Id: I2f4e67b617fc410365b664087a1f0abc0691ac4f
---
M i18n/qqq.json
M src/RevisionSliderHooks.php
2 files changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/RevisionSlider
refs/changes/62/354662/1
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 612c6ff..714f3c2 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -20,6 +20,7 @@
"revisionslider-label-comment": "Label for the edit summary of the
revision.\n{{Identical|Comment}}",
"revisionslider-label-username": "Label for the revision's author's
username.\n\nParameters:\n$1 - Gender as in user preferences (suitable for
GENDER)\n{{Identical|Username}}",
"revisionslider-minoredit": "Text labeling a minor edit.",
+ "revisionslider-loading-placeholder": "Message shown while the
RevisionSlider is still loading on a diff page. Once loaded the message is
removed.",
"revisionslider-loading-failed": "Message shown if the RevisionSlider
fails to initially load.",
"revisionslider-toggle-title-expand": "Message shown as a \"title\" of
the exand button",
"revisionslider-toggle-title-collapse": "Message shown as a \"title\"
of the collapse button",
diff --git a/src/RevisionSliderHooks.php b/src/RevisionSliderHooks.php
index 2cabf66..39913ec 100644
--- a/src/RevisionSliderHooks.php
+++ b/src/RevisionSliderHooks.php
@@ -89,8 +89,6 @@
] );
$toggleButton->setAttributes( [ 'style' => 'width: 100%;
text-align: center;' ] );
- $progressBar = new OOUI\ProgressBarWidget( [ 'progress' =>
false ] );
-
$out->prependHTML(
Html::rawElement(
'div', [ 'class' => 'mw-revslider-container' ],
@@ -103,7 +101,7 @@
],
Html::rawElement(
'div', [ 'class' =>
'mw-revslider-placeholder' ],
- $progressBar
+ ( new Message(
'revisionslider-loading-placeholder' ) )->text()
)
)
)
--
To view, visit https://gerrit.wikimedia.org/r/354662
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2f4e67b617fc410365b664087a1f0abc0691ac4f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: REL1_27
Gerrit-Owner: Addshore <addshorew...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
