Aude has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/354713 )

Change subject: Use PageImages::PROP_NAME_FREE page prop for commons media 
values
......................................................................

Use PageImages::PROP_NAME_FREE page prop for commons media values

page_image / page_image_free page prop is only set for commons media
property values.

Wikimedia Commons has policy of only hosting free images:

https://meta.wikimedia.org/wiki/Non-free_content#Other_projects

So we should be able to use PageImages::PROP_NAME_FREE page prop.

(see also T156190 which would allow configuring Wikidata to
get retrieve free or 'any' (the old 'page_image') images from
the pageprop query api, to help fix Special:Nearby, mobile search
suggestions, etc. without having to purge pages to update the
page prop.)

Bug: T159678
Change-Id: I5317b5fdafde0331d33f3d8182682e528c312424
---
M repo/includes/ParserOutput/EntityParserOutputGeneratorFactory.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/13/354713/1

diff --git a/repo/includes/ParserOutput/EntityParserOutputGeneratorFactory.php 
b/repo/includes/ParserOutput/EntityParserOutputGeneratorFactory.php
index a01b476..82db285 100644
--- a/repo/includes/ParserOutput/EntityParserOutputGeneratorFactory.php
+++ b/repo/includes/ParserOutput/EntityParserOutputGeneratorFactory.php
@@ -191,7 +191,7 @@
                if ( !empty( $this->preferredPageImagesProperties ) && 
class_exists( 'PageImages' ) ) {
                        $updaters[] = new PageImagesDataUpdater(
                                $this->preferredPageImagesProperties,
-                               PageImages::PROP_NAME
+                               PageImages::PROP_NAME_FREE
                        );
                }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/354713
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5317b5fdafde0331d33f3d8182682e528c312424
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to