Catrope has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/354908 )
Change subject: ve.Node#attach: set document before root, rather than after
......................................................................
ve.Node#attach: set document before root, rather than after
onRoot event handlers expect a document to be set. Swapping this
is safe because setDocument() doesn't fire events.
Change-Id: I9169f097f61aee0be12b62d887e4e3ef9c82a7a9
---
M src/ve.Node.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/08/354908/1
diff --git a/src/ve.Node.js b/src/ve.Node.js
index d5b8b72..55a4031 100644
--- a/src/ve.Node.js
+++ b/src/ve.Node.js
@@ -366,8 +366,8 @@
*/
ve.Node.prototype.attach = function ( parent ) {
this.parent = parent;
- this.setRoot( parent.getRoot() );
this.setDocument( parent.getDocument() );
+ this.setRoot( parent.getRoot() );
this.emit( 'attach', parent );
};
--
To view, visit https://gerrit.wikimedia.org/r/354908
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9169f097f61aee0be12b62d887e4e3ef9c82a7a9
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
