jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/354505 )
Change subject: Use WikiPage::makeParserOptions to get options for caching
......................................................................
Use WikiPage::makeParserOptions to get options for caching
MediaWiki core change I7fb9ffca9 is going to cause
WikiPage::getParserOutput() to start throwing an exception if it is
passed a ParserOptions object with non-canonical values for options that
don't fragment the cache. While the code here should be ok (assuming
$wgEnableParserLimitReporting isn't false), let's update it to be safe.
Bug: T110269
Change-Id: I4c6973077de989fd5e64068915108fc33f6cb3de
---
M repo/includes/Diff/EntityContentDiffView.php
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
Hoo man: Looks good to me, but someone else must approve
jenkins-bot: Verified
Thiemo Mättig (WMDE): Looks good to me, approved
diff --git a/repo/includes/Diff/EntityContentDiffView.php
b/repo/includes/Diff/EntityContentDiffView.php
index db40e15..4cde0a7 100644
--- a/repo/includes/Diff/EntityContentDiffView.php
+++ b/repo/includes/Diff/EntityContentDiffView.php
@@ -210,9 +210,7 @@
* @return ParserOutput
*/
protected function getParserOutput( WikiPage $page, Revision $rev ) {
- $parserOptions = ParserOptions::newFromContext(
$this->getContext() );
- $parserOptions->enableLimitReport();
- $parserOptions->setTidy( true );
+ $parserOptions = $page->makeParserOptions( $this->getContext()
);
$parserOptions->setEditSection( false );
// Do not poison parser cache with diff-specific stuff
--
To view, visit https://gerrit.wikimedia.org/r/354505
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4c6973077de989fd5e64068915108fc33f6cb3de
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Anomie <[email protected]>
Gerrit-Reviewer: Anomie <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
