Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/354932 )

Change subject: Do the echo when running update.php
......................................................................

Do the echo when running update.php

Otherwise it's vaguely out of order being done due to subprocesses

Change-Id: I2e40e4e22be8a4af8e1dfe843163552144969af2
---
M modules/beta/files/wmf-beta-update-databases.py
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/32/354932/1

diff --git a/modules/beta/files/wmf-beta-update-databases.py 
b/modules/beta/files/wmf-beta-update-databases.py
index f7ce81b..17378f3 100755
--- a/modules/beta/files/wmf-beta-update-databases.py
+++ b/modules/beta/files/wmf-beta-update-databases.py
@@ -44,9 +44,8 @@
     with open(staging, "r") as dblist:
         for db in dblist:
             db = db.strip()
-            print db
             f = os.tmpfile()
-            cmd = "/usr/local/bin/mwscript update.php --wiki=%s --quick" % db
+            cmd = "echo %(db); /usr/local/bin/mwscript update.php --wiki=%(db) 
--quick" % {'db': db}
             p = subprocess.Popen(cmd, stdout=f, stderr=f, shell=True)
             procs.append((p, f, cmd))
             if (len(procs) >= cores):

-- 
To view, visit https://gerrit.wikimedia.org/r/354932
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2e40e4e22be8a4af8e1dfe843163552144969af2
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Reedy <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to