jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/355247 )

Change subject: Remove dialog height hack tagged against resolved bug
......................................................................


Remove dialog height hack tagged against resolved bug

Bug: T93290
Change-Id: Idbb20a0adf854ba68e10043608764891f3d8514d
---
M modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js
1 file changed, 1 insertion(+), 4 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js 
b/modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js
index 8bcdbdd..180f60b 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js
@@ -36,10 +36,7 @@
 ve.ui.MWTransclusionDialog.static.actions = 
ve.ui.MWTemplateDialog.static.actions.concat( [
        {
                action: 'mode',
-               modes: [ 'edit', 'insert' ],
-               // HACK: Will be set later, but we want measurements to be 
accurate in the mean time, this
-               // will not be needed when T93290 is resolved
-               label: $( document.createTextNode( '\u00a0' ) )
+               modes: [ 'edit', 'insert' ]
        }
 ] );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/355247
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idbb20a0adf854ba68e10043608764891f3d8514d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to