jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/355128 )
Change subject: html2wt: Document a check in LinkHandler
......................................................................
html2wt: Document a check in LinkHandler
Change-Id: If04843fc14bafd19c920dd2d545723173450d96b
---
M lib/html2wt/LinkHandler.js
1 file changed, 8 insertions(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
Arlolra: Looks good to me, approved
diff --git a/lib/html2wt/LinkHandler.js b/lib/html2wt/LinkHandler.js
index 4cfbc4c..b2db533 100644
--- a/lib/html2wt/LinkHandler.js
+++ b/lib/html2wt/LinkHandler.js
@@ -549,7 +549,14 @@
linkTarget = escapedTgt.linkTarget;
}
- // FIXME: Is the "!target.fromsrc" check
necessary below?
+ // If we are reusing the target from source, we
don't
+ // need to worry about colon-escaping because
it will
+ // be in the right form already.
+ //
+ // Trying to eliminate this check and always
check for
+ // colon-escaping seems a bit tricky when the
reused
+ // target has encoded entities that won't
resolve to
+ // valid titles.
if ((!escapedTgt || !escapedTgt.invalidLink) &&
!target.fromsrc) {
linkTarget = addColonEscape(env,
linkTarget, linkData);
}
--
To view, visit https://gerrit.wikimedia.org/r/355128
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If04843fc14bafd19c920dd2d545723173450d96b
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry <[email protected]>
Gerrit-Reviewer: Arlolra <[email protected]>
Gerrit-Reviewer: C. Scott Ananian <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
