Bmansurov has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/355559 )
Change subject: API: Limit maximum number of characters when `exchars` is
passed.
......................................................................
API: Limit maximum number of characters when `exchars` is passed.
Set the limit to 1200 characters.
Bug: T156467
Change-Id: I4e53b26a3f57f5f5cf7acbd3702c8bc4541a5eb5
---
M includes/ApiQueryExtracts.php
M tests/phpunit/ApiQueryExtractsTest.php
2 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TextExtracts
refs/changes/59/355559/1
diff --git a/includes/ApiQueryExtracts.php b/includes/ApiQueryExtracts.php
index b839321..097739c 100644
--- a/includes/ApiQueryExtracts.php
+++ b/includes/ApiQueryExtracts.php
@@ -377,6 +377,7 @@
'chars' => [
ApiBase::PARAM_TYPE => 'integer',
ApiBase::PARAM_MIN => 1,
+ ApiBase::PARAM_MAX => 1200,
],
'sentences' => [
ApiBase::PARAM_TYPE => 'integer',
diff --git a/tests/phpunit/ApiQueryExtractsTest.php
b/tests/phpunit/ApiQueryExtractsTest.php
index 1ab17c4..6c8d317 100644
--- a/tests/phpunit/ApiQueryExtractsTest.php
+++ b/tests/phpunit/ApiQueryExtractsTest.php
@@ -39,6 +39,9 @@
$instance = $this->newInstance();
$params = $instance->getAllowedParams();
$this->assertInternalType( 'array', $params );
+ $this->assertArrayHasKey( 'chars', $params );
+ $this->assertEquals( $params['chars'][\ApiBase::PARAM_MIN], 1 );
+ $this->assertEquals( $params['chars'][\ApiBase::PARAM_MAX],
1200 );
$this->assertArrayHasKey( 'limit', $params );
$this->assertEquals( $params['limit'][\ApiBase::PARAM_DFLT], 20
);
$this->assertEquals( $params['limit'][\ApiBase::PARAM_TYPE],
'limit' );
--
To view, visit https://gerrit.wikimedia.org/r/355559
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4e53b26a3f57f5f5cf7acbd3702c8bc4541a5eb5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TextExtracts
Gerrit-Branch: master
Gerrit-Owner: Bmansurov <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
