Arlolra has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/355575 )
Change subject: Don't modify passed in apiConf
......................................................................
Don't modify passed in apiConf
* It prevents reuse of parsoidOptions, relevant to an upcoming patch.
Change-Id: Ic27f1e0feba0ae5c3e172d70f0b4c2d6ec079ca2
---
M lib/config/ParsoidConfig.js
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid
refs/changes/75/355575/1
diff --git a/lib/config/ParsoidConfig.js b/lib/config/ParsoidConfig.js
index 8104935..7addddd 100644
--- a/lib/config/ParsoidConfig.js
+++ b/lib/config/ParsoidConfig.js
@@ -458,11 +458,14 @@
} else if (typeof arguments[1] === 'object') {
// Note that `apiConf` is aliased to `arguments[0]`.
prefix = arguments[0];
- apiConf = arguments[1]; // overwrites `arguments[0]`
+ apiConf = Object.assign({}, arguments[1]); //
overwrites `arguments[0]`
apiConf.prefix = prefix;
} else {
apiConf = { uri: arguments[0] };
}
+ } else {
+ console.assert(typeof apiConf === 'object');
+ apiConf = Object.assign({}, apiConf); // Don't modify the
passed in object
}
console.assert(apiConf.uri, "Action API uri is mandatory.");
if (!apiConf.prefix) {
--
To view, visit https://gerrit.wikimedia.org/r/355575
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic27f1e0feba0ae5c3e172d70f0b4c2d6ec079ca2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Arlolra <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
