VolkerE has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/355611 )
Change subject: WikimediaUI theme: Remove incorrect comments ...................................................................... WikimediaUI theme: Remove incorrect comments Color explanation comments have been diverted from code, let's remove them for accuracy. Change-Id: I5c683073142c2d126b66f4b252eb64d3a514d066 --- M src/themes/wikimediaui/common.less 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/11/355611/1 diff --git a/src/themes/wikimediaui/common.less b/src/themes/wikimediaui/common.less index 48dfbfe..d74f8fa 100644 --- a/src/themes/wikimediaui/common.less +++ b/src/themes/wikimediaui/common.less @@ -17,7 +17,7 @@ @color-subtle: #72777d; // Primary 'Progressive' and 'Destructive' Colors -@background-color-progressive: #eaf3ff; // equals rgba output in `fade( @color-progressive, 10% )` +@background-color-progressive: #eaf3ff; @background-color-progressive-hover: rgba( 41, 98, 204, 0.1 ); @color-progressive: #36c; // equals HSB 220°/75%/80% @color-progressive-hover: #447ff5; // equals HSB 220°/72%/96% @@ -25,7 +25,7 @@ @color-progressive-active-hover: @color-progressive; @color-progressive-focus: @color-progressive; -@background-color-destructive: #fee7e6; // Doesn't equal `fade( @color-destructive, 10% )` but is close. +@background-color-destructive: #fee7e6; @color-destructive: #d33; // equals HSB 360°/77%/87% @color-destructive-non-primary: #d73333; // Exemption for non-primary buttons, foremost used in VE, lightened up R50 to align to AA contrast ratio @color-destructive-hover: #ff4242; // equals HSB 360°/74%/100% @@ -47,7 +47,7 @@ // "Framed" Widgets (Framed ButtonWidget, ToggleSwitchWidget...) @background-color-framed: #f8f9fa; -@background-color-framed-hover: @background-color-default; //fade( @color-default, 10% ); +@background-color-framed-hover: @background-color-default; // equals `lighten( #f8f9fa, 10% )`, although `2%` is already resulting in `#fff` @background-color-framed-active: #c8ccd1; // Tabbed Navigation -- To view, visit https://gerrit.wikimedia.org/r/355611 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5c683073142c2d126b66f4b252eb64d3a514d066 Gerrit-PatchSet: 1 Gerrit-Project: oojs/ui Gerrit-Branch: master Gerrit-Owner: VolkerE <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
