jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/341333 )

Change subject: Replace the use of &$this
......................................................................


Replace the use of &$this

Use of &$this doesn't work in PHP 7.1, so it has been replaced with $this.

Bug: T153505
Change-Id: Iccf692c66ee9520687ecec9ba9c90e4ab58cb339
---
M includes/ContestContestant.php
1 file changed, 4 insertions(+), 5 deletions(-)

Approvals:
  Krinkle: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/ContestContestant.php b/includes/ContestContestant.php
index a1a904c..d362622 100644
--- a/includes/ContestContestant.php
+++ b/includes/ContestContestant.php
@@ -454,10 +454,9 @@
         * @return bool
         */
        protected function insertIntoDB() {
-               wfRunHooks( 'ContestBeforeContestantInsert', array( &$this ) );
+               wfRunHooks( 'ContestBeforeContestantInsert', array( $this ) );
 
                $success = parent::insertIntoDB();
-
                if ( $success ) {
                        $this->onUserSignup();
                }
@@ -478,7 +477,7 @@
 
                $this->sendSignupEmail();
 
-               wfRunHooks( 'ContestAfterContestantInsert', array( &$this ) );
+               wfRunHooks( 'ContestAfterContestantInsert', array( $this ) );
        }
 
        /**
@@ -495,7 +494,7 @@
                $sender = ContestSettings::get( 'mailSender' );
                $senderName = ContestSettings::get( 'mailSenderName' );
 
-               wfRunHooks( 'ContestBeforeSignupEmail', array( &$this, &$title, 
&$emailText, &$user, &$sender, &$senderName ) );
+               wfRunHooks( 'ContestBeforeSignupEmail', array( $this, &$title, 
&$emailText, &$user, &$sender, &$senderName ) );
 
                return UserMailer::send(
                        new MailAddress( $user ),
@@ -523,7 +522,7 @@
                $sender = ContestSettings::get( 'mailSender' );
                $senderName = ContestSettings::get( 'mailSenderName' );
 
-               wfRunHooks( 'ContestBeforeReminderEmail', array( &$this, 
&$title, &$emailText, &$user, &$sender, &$senderName ) );
+               wfRunHooks( 'ContestBeforeReminderEmail', array( $this, 
&$title, &$emailText, &$user, &$sender, &$senderName ) );
 
                return UserMailer::send(
                        new MailAddress( $user ),

-- 
To view, visit https://gerrit.wikimedia.org/r/341333
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iccf692c66ee9520687ecec9ba9c90e4ab58cb339
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Contest
Gerrit-Branch: master
Gerrit-Owner: Amritsreekumar <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to