jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/342869 )
Change subject: Purge formulae on action=purge
......................................................................
Purge formulae on action=purge
Previously, the 'action=purge' parameter could not be
accessed by the math extension, since 'action=purge' caused a reload
of the page, even before the math extension was called. However,
before MediaWiki 1.29.+ additional GET request parameter were
forwarded to the next page and could be evaluated by the math
extension. Thus, an additional parameter 'mathpurge=true' was added
to re-render formulae. However, it seems that this additional GET
parameter is no longer being forwarded.
This change reads the refer header to check if 'action=purge' was
passed. This makes the mathpurge parameter obsolete.
Bug: T74537
Change-Id: Ia09c039de3a7232a28bfdd5a97daf1029e5d7c40
---
M MathRenderer.php
1 file changed, 8 insertions(+), 10 deletions(-)
Approvals:
Mobrovac: Looks good to me, approved
jenkins-bot: Verified
diff --git a/MathRenderer.php b/MathRenderer.php
index b6916eb..99216f8 100644
--- a/MathRenderer.php
+++ b/MathRenderer.php
@@ -522,17 +522,15 @@
if ( $this->purge ) {
return true;
}
- $request = RequestContext::getMain()->getRequest();
- // TODO: Figure out if ?action=purge
- // $action = $request->getText('action'); //always returns ''
- // until this issue is resolved we use ?mathpurge=true instead
- $mathpurge = $request->getBool( 'mathpurge', false );
- if ( $mathpurge ) {
- LoggerFactory::getInstance( 'Math' )->debug(
'Re-Rendering on user request' );
- return true;
- } else {
- return false;
+ $refererHeader =
RequestContext::getMain()->getRequest()->getHeader( 'REFERER' );
+ if ( $refererHeader ) {
+ parse_str( parse_url( $refererHeader, PHP_URL_QUERY ),
$refererParam );
+ if ( isset( $refererParam['action'] ) &&
$refererParam['action'] === 'purge' ) {
+ LoggerFactory::getInstance( 'Math' )->debug(
'Re-Rendering on user request' );
+ return true;
+ }
}
+ return false;
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/342869
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia09c039de3a7232a28bfdd5a97daf1029e5d7c40
Gerrit-PatchSet: 6
Gerrit-Project: mediawiki/extensions/Math
Gerrit-Branch: master
Gerrit-Owner: Physikerwelt <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Mobrovac <[email protected]>
Gerrit-Reviewer: Physikerwelt <[email protected]>
Gerrit-Reviewer: TheDJ <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
