Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/356419 )
Change subject: eslint: Fix valid-jsdoc issues
......................................................................
eslint: Fix valid-jsdoc issues
Leave rule disabled due to @chainable issue.
Change-Id: I1277cc59c6cb9d3436168caa8125c6d19f87c8c1
---
M src/EventEmitter.js
M src/SortedEmitterList.js
2 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/core refs/changes/19/356419/1
diff --git a/src/EventEmitter.js b/src/EventEmitter.js
index 8e33693..3e9d05d 100644
--- a/src/EventEmitter.js
+++ b/src/EventEmitter.js
@@ -53,17 +53,17 @@
/**
* @private
- * @param {OO.EventEmitter} ee
- * @param {Function|string} method Function or method name
+ * @param {OO.EventEmitter} eventEmitter Event emitter
+ * @param {string} event Event name
* @param {Object} binding
*/
- function addBinding( ee, event, binding ) {
+ function addBinding( eventEmitter, event, binding ) {
var bindings;
// Auto-initialize bindings list
- if ( hasOwn.call( ee.bindings, event ) ) {
- bindings = ee.bindings[ event ];
+ if ( hasOwn.call( eventEmitter.bindings, event ) ) {
+ bindings = eventEmitter.bindings[ event ];
} else {
- bindings = ee.bindings[ event ] = [];
+ bindings = eventEmitter.bindings[ event ] = [];
}
// Add binding
bindings.push( binding );
@@ -81,8 +81,8 @@
* @param {Function|string} method Function or method name to call when
event occurs
* @param {Array} [args] Arguments to pass to listener, will be
prepended to emitted arguments
* @param {Object} [context=null] Context object for function or method
call
- * @throws {Error} Listener argument is not a function or a valid
method name
* @chainable
+ * @throws {Error} Listener argument is not a function or a valid
method name
*/
oo.EventEmitter.prototype.on = function ( event, method, args, context
) {
validateMethod( method, context );
diff --git a/src/SortedEmitterList.js b/src/SortedEmitterList.js
index 38f9862..28a2184 100644
--- a/src/SortedEmitterList.js
+++ b/src/SortedEmitterList.js
@@ -83,9 +83,9 @@
/**
* Add items to the sorted list.
*
- * @chainable
* @param {OO.EventEmitter|OO.EventEmitter[]} items Item to add or
* an array of items to add
+ * @chainable
*/
oo.SortedEmitterList.prototype.addItems = function ( items ) {
var index, i, insertionIndex;
--
To view, visit https://gerrit.wikimedia.org/r/356419
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1277cc59c6cb9d3436168caa8125c6d19f87c8c1
Gerrit-PatchSet: 1
Gerrit-Project: oojs/core
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
