Inez has uploaded a new change for review.
https://gerrit.wikimedia.org/r/52575
Change subject: Fix for IE bug with clearTimeout.
......................................................................
Fix for IE bug with clearTimeout.
Apparently in IE even after you call clearTimeout function which you passed
before to
setTimeout will get executed - not 100% of the time - it depends on the time
difference
between calling clearTimeout and when that function was supposed to be called.
Change-Id: I050c1ecc51c1d891a028fb777243573487357171
---
M modules/ve/ce/ve.ce.SurfaceObserver.js
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/75/52575/1
diff --git a/modules/ve/ce/ve.ce.SurfaceObserver.js
b/modules/ve/ce/ve.ce.SurfaceObserver.js
index 069e95f..833215d 100644
--- a/modules/ve/ce/ve.ce.SurfaceObserver.js
+++ b/modules/ve/ce/ve.ce.SurfaceObserver.js
@@ -95,6 +95,10 @@
ve.ce.SurfaceObserver.prototype.poll = function ( async ) {
var delayPoll, $branch, node, text, hash, range, rangyRange;
+ if ( this.polling === false ) {
+ return;
+ }
+
if ( this.timeoutId !== null ) {
clearTimeout( this.timeoutId );
this.timeoutId = null;
--
To view, visit https://gerrit.wikimedia.org/r/52575
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I050c1ecc51c1d891a028fb777243573487357171
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Inez <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
