jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/356501 )
Change subject: Replace uses of the removed 'remove' icon with the 'trash' one ...................................................................... Replace uses of the removed 'remove' icon with the 'trash' one Bug: T166730 Change-Id: I528dcdb390a4488ffac89fc823ff35bc1eda4f24 --- M extension.json M modules/ve-mw/ui/pages/ve.ui.MWParameterPlaceholderPage.js M modules/ve-mw/ui/pages/ve.ui.MWTemplatePage.js M modules/ve-mw/ui/pages/ve.ui.MWTemplatePlaceholderPage.js M modules/ve-mw/ui/pages/ve.ui.MWTransclusionContentPage.js M modules/ve-mw/ui/widgets/ve.ui.MWCategoryPopupWidget.js 6 files changed, 6 insertions(+), 5 deletions(-) Approvals: Catrope: Looks good to me, approved jenkins-bot: Verified diff --git a/extension.json b/extension.json index adc3be9..d930692 100644 --- a/extension.json +++ b/extension.json @@ -2020,6 +2020,7 @@ "oojs-ui.styles.icons-editing-core", "oojs-ui.styles.icons-editing-styling", "oojs-ui.styles.icons-editing-list", + "oojs-ui.styles.icons-moderation", "oojs-ui.styles.indicators", "oojs-ui.styles.textures", "ext.visualEditor.moduleIcons", diff --git a/modules/ve-mw/ui/pages/ve.ui.MWParameterPlaceholderPage.js b/modules/ve-mw/ui/pages/ve.ui.MWParameterPlaceholderPage.js index e822a0b..62e7e3c 100644 --- a/modules/ve-mw/ui/pages/ve.ui.MWParameterPlaceholderPage.js +++ b/modules/ve-mw/ui/pages/ve.ui.MWParameterPlaceholderPage.js @@ -39,7 +39,7 @@ this.removeButton = new OO.ui.ButtonWidget( { framed: false, - icon: 'remove', + icon: 'trash', title: ve.msg( 'visualeditor-dialog-transclusion-remove-param' ), flags: [ 'destructive' ], classes: [ 've-ui-mwTransclusionDialog-removeButton' ] diff --git a/modules/ve-mw/ui/pages/ve.ui.MWTemplatePage.js b/modules/ve-mw/ui/pages/ve.ui.MWTemplatePage.js index 571d519..6adf3ac 100644 --- a/modules/ve-mw/ui/pages/ve.ui.MWTemplatePage.js +++ b/modules/ve-mw/ui/pages/ve.ui.MWTemplatePage.js @@ -35,7 +35,7 @@ this.$description = $( '<div>' ); this.removeButton = new OO.ui.ButtonWidget( { framed: false, - icon: 'remove', + icon: 'trash', title: ve.msg( 'visualeditor-dialog-transclusion-remove-template' ), flags: [ 'destructive' ], classes: [ 've-ui-mwTransclusionDialog-removeButton' ] diff --git a/modules/ve-mw/ui/pages/ve.ui.MWTemplatePlaceholderPage.js b/modules/ve-mw/ui/pages/ve.ui.MWTemplatePlaceholderPage.js index 553058d..a75eabd 100644 --- a/modules/ve-mw/ui/pages/ve.ui.MWTemplatePlaceholderPage.js +++ b/modules/ve-mw/ui/pages/ve.ui.MWTemplatePlaceholderPage.js @@ -49,7 +49,7 @@ this.removeButton = new OO.ui.ButtonWidget( { framed: false, - icon: 'remove', + icon: 'trash', title: ve.msg( 'visualeditor-dialog-transclusion-remove-template' ), flags: [ 'destructive' ], classes: [ 've-ui-mwTransclusionDialog-removeButton' ] diff --git a/modules/ve-mw/ui/pages/ve.ui.MWTransclusionContentPage.js b/modules/ve-mw/ui/pages/ve.ui.MWTransclusionContentPage.js index 0d1a99e..15c5cab 100644 --- a/modules/ve-mw/ui/pages/ve.ui.MWTransclusionContentPage.js +++ b/modules/ve-mw/ui/pages/ve.ui.MWTransclusionContentPage.js @@ -36,7 +36,7 @@ .connect( this, { change: 'onTextInputChange' } ); this.removeButton = new OO.ui.ButtonWidget( { framed: false, - icon: 'remove', + icon: 'trash', title: ve.msg( 'visualeditor-dialog-transclusion-remove-content' ), flags: [ 'destructive' ], classes: [ 've-ui-mwTransclusionDialog-removeButton' ] diff --git a/modules/ve-mw/ui/widgets/ve.ui.MWCategoryPopupWidget.js b/modules/ve-mw/ui/widgets/ve.ui.MWCategoryPopupWidget.js index 4ad25a7..3deb53a 100644 --- a/modules/ve-mw/ui/widgets/ve.ui.MWCategoryPopupWidget.js +++ b/modules/ve-mw/ui/widgets/ve.ui.MWCategoryPopupWidget.js @@ -29,7 +29,7 @@ this.$menu = $( '<div>' ); this.removeButton = new OO.ui.ButtonWidget( { framed: false, - icon: 'remove', + icon: 'trash', title: ve.msg( 'visualeditor-inspector-remove-tooltip' ) } ); this.sortKeyInput = new OO.ui.TextInputWidget(); -- To view, visit https://gerrit.wikimedia.org/r/356501 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I528dcdb390a4488ffac89fc823ff35bc1eda4f24 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Jforrester <jforres...@wikimedia.org> Gerrit-Reviewer: Catrope <r...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits